Don't show module chromes of disabled templates #21437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 7d438bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21437. |
|
I must be missing something but how do you disable a template |
|
Through Extension Manager. |
|
I have tested this item ✅ successfully on 7d438bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21437. |
|
Ready to Commit after two successful tests. |
joomla-cms-bot
added
PR-staging
and removed
RTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #21429.
Summary of Changes
This filters out module chromes of disabled templates from chrome field.
Testing Instructions
Disable a template. Edit a module. Check available chromes in
Module Stylefield.Expected result
Modules chromes of disabled templates are not shown.
Actual result
Modules chromes of disabled templates are shown.
Documentation Changes Required
No.