Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUX2] [01] Moved actions (on hover) dropdown to status buttons #2163

Merged
merged 5 commits into from Oct 9, 2013
Merged

[JUX2] [01] Moved actions (on hover) dropdown to status buttons #2163

merged 5 commits into from Oct 9, 2013

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2013

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31858

Before the dropdown only shows on hover over table row next to the title.
Now it is always visible in the Status column.
This also solves accessibility issues (being able to tab to items, etc).

tooltips

@beat
Copy link
Contributor

beat commented Oct 7, 2013

Tested thoroughly and successfully (also added 2nd "­test success" on FR. So this one is ready with 2 tests.

Good job @nonumber 👍

beat and others added 2 commits October 8, 2013 12:38
@dbhurley
Copy link

dbhurley commented Oct 9, 2013

The unpublish icon sizes seem to vary between articles and modules before/after this PR. Articles is wrong both before and after, modules appears to be right before and then wrong after this PR.

It's purely a CSS issue but would be nice to clean it up all the way around.

@beat
Copy link
Contributor

beat commented Oct 9, 2013

@dbhurley i can't reproduce this icon size issue here (Firefox latest/Linux). Which browser/OS do you use ?

@ghost
Copy link
Author

ghost commented Oct 9, 2013

Icon size stuff fixed in master. So this can be merged...

davidhurley pushed a commit that referenced this pull request Oct 9, 2013
[JUX2] [01] Moved actions (on hover) dropdown to status buttons
@davidhurley davidhurley merged commit 870478b into joomla:master Oct 9, 2013
@ghost ghost deleted the jux-actions branch October 9, 2013 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants