Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig to this repository #21686

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Conversation

wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Aug 18, 2018

Pull Request for Issue #21633 (comment)

Summary of Changes

Adds .editorconfig to this repository

Testing Instructions

code revie and check if file is working, see http://editorconfig.org for details

Expected result

.editorconfig in this repository.

Actual result

No .editorconfig in this repository.

Documentation Changes Required

N/A

cc @rdeutz @dgrammatiko

@brianteeman
Copy link
Contributor

@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 18, 2018

@brianteeman I know that but see comments in linked PR.

@rdeutz
Copy link
Contributor

rdeutz commented Aug 18, 2018

final decision should do @mbabker but you have my support

@mbabker mbabker merged commit 2cd00da into joomla:staging Aug 18, 2018
@wojsmol wojsmol deleted the edutorconfig branch August 18, 2018 15:32
@zero-24 zero-24 added this to the Joomla 3.8.12 milestone Aug 19, 2018
@mbabker mbabker removed this from the Joomla 3.8.12 milestone Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants