Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug from calendar field as it breaks saving to the DB #21717

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

wilsonge
Copy link
Contributor

Fixes #19607

When you have language debug enabled the calendar dates will not save to the db as they are in the incorrect format. We can't show these in debug mode. This is similar to the fix for e.g in the template adapter.

Note in 4.x this gives an error correctly but in 3.x will silently insert an empty string to the db

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 9474e5a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21717.

@mbabker mbabker added this to the Joomla 3.8.12 milestone Aug 21, 2018
@mbabker mbabker merged commit d189796 into joomla:staging Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants