Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes installer leftovers in the Joomla tmp folder after unsuccessful installation with wrong file type #2172

Closed
wants to merge 5 commits into from

Conversation

beat
Copy link
Contributor

@beat beat commented Oct 8, 2013

This PR includes already #2143 so should be MERGED AFTER #2143 .

Related tracker issue item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32207

To test:

  1. Check that your joomla tmp folder is empty
  2. Try insatlling a pdf file with all 3 existing methods and verify that they are not installed, and see that there are files leftover in tmp
  3. Empty your tmp folder
  4. Apply patch
  5. Try insatlling a pdf file with all 3 methods and verify that they are not installed, but also that now with the patch there are no leftovers in the tmp folder.
  6. install an extension by all 4 methods and verify for each that it is still installed correctly, and that there are still no leftovers in tmp

BTW: this is NOT a vulnerability or security issue, as only super-admins have installation rights, and with those rights, they can store files already in the media manager, or install components that allow file access.

@beat
Copy link
Contributor Author

beat commented Oct 9, 2013

I have rebased the branch to latest master now that PR #2143 has been merged to master. So the diff is much easier now :-)

@mbabker mbabker closed this in 7dbda4e Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant