Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Batch menu items: Translate the menu item title when client is administrator #21748

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

infograf768
Copy link
Member

Summary of Changes

As title says

Testing Instructions

Staging or last 3.8.x version.
Create a custom admin menu using preset.
Display the menu items for this menu in the menu items Manager.
Select an item and click on batch.
The modal displays.

Before patch

The items are not translated.

screen shot 2018-08-20 at 07 21 34

After patch

screen shot 2018-08-20 at 06 45 35

Documentation Changes Required

None

@ghost
Copy link

ghost commented Aug 20, 2018

I have tested this item ✅ successfully on d55db9e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21748.

@infograf768 infograf768 added this to the Joomla 3.8.12 milestone Aug 20, 2018
@alikon
Copy link
Contributor

alikon commented Aug 20, 2018

I have tested this item ✅ successfully on d55db9e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21748.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.12 milestone Aug 20, 2018
@ghost
Copy link

ghost commented Aug 20, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 20, 2018
@mbabker mbabker added this to the Joomla 3.8.12 milestone Aug 21, 2018
@mbabker mbabker merged commit bc2b16e into joomla:staging Aug 21, 2018
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Aug 21, 2018
@infograf768 infograf768 deleted the translate_admin_menu_item branch August 21, 2018 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants