Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced ACL for com_modules, permissions per module #234

Closed
wants to merge 12 commits into from
Closed

Advanced ACL for com_modules, permissions per module #234

wants to merge 12 commits into from

Conversation

sanderpotjer
Copy link
Member

I noticed that a lot of people that are using the Joomla ACL system are looking for permission support per module and not just for the entire com_modules component.

This patch adds advanced ACL to com_modules and allows to set permissions (delete, edit & edit.state) per module.

@sanderpotjer
Copy link
Member Author

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28638

@Craiggf
Copy link

Craiggf commented Jul 3, 2012

tried to apply to 2.5.x and got the following....am new to github let me know if I erred somehow....

warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.
Applying: Installation script updates for module ACL support
Applying: Improvements & corrections for the default assets table data
Applying: Update of sample_data.sql files
error: patch failed: installation/sql/mysql/sample_data.sql:536
error: installation/sql/mysql/sample_data.sql: patch does not apply
Patch failed at 0004 Update of sample_data.sql files
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
C:\wamp\www\joomla-cms [2.5.x +0 ~0 -297]>

@linhos82
Copy link

linhos82 commented Jun 7, 2013

Hello sanderpotjer, okay, I'm from Brazil and I need to implement this functionality in my website joomla, ACL com_module, I wonder if these files are ready for Joomla 2.5 and Joomla 3.0 only because I am still working with joomla 2.5 and need acl modules for this platform. I await contact and if possible a greater explanation of how to modify these files

mahagr
mahagr reviewed Jun 7, 2013
View reviewed changes
administrator/components/com_modules/helpers/modules.php
$actions = JAccess::getActions('com_modules');

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to merge conflicts in here..?

@mahagr
Copy link
Contributor

mahagr commented Jun 7, 2013

Your latest version has a few merge conflicts which were not looked upon. Can you fix the source code?

@linhos82
Copy link

linhos82 commented Jun 7, 2013

Sorry, but I do not I schedule, unfortunately I do not understand, but I communicated a forum for joomla here from Brazil about your problem, and programmer Bruno Batista one of the best in my opinion here in Brazil will help contribute. See you soon!

*For joomla 2.5 and it already possible? I need use in joomla 2.5 this ACL per module

@sanderpotjer
Copy link
Member Author

I'm currently on holiday but will finish an updated patch for Joomla 3 soon. Glad to see interest now!

Sander

Op 7 jun. 2013 om 13:12 heeft linhos82 notifications@github.com het volgende geschreven:

Sorry, but I do not I schedule, unfortunately I do not understand, but I communicated a forum for joomla here from Brazil about your problem, and programmer Bruno Batista one of the best in my opinion here in Brazil will help contribute. See you soon!

—
Reply to this email directly or view it on GitHub.

@sanderpotjer
Copy link
Member Author

Will do a new pull request for Joomla 3.x, will close this one

@sanderpotjer
Copy link
Member Author

Please see the new pull request for this one: #1368

@sanderpotjer sanderpotjer deleted the modules-acl branch June 27, 2013 20:54
wilsonge pushed a commit that referenced this pull request Jan 23, 2017
@ciar4n
Merge pull request #234 from C-Lodder/scss-stuff
f06e5de 
SCSS structure improvement & responsive utility class updates
wilsonge pushed a commit that referenced this pull request Jun 4, 2017
@ciar4n @laoneo
Close 2nd level menu (#234)
b83239b
wilsonge pushed a commit to wilsonge/joomla-cms that referenced this pull request May 26, 2019
@nadjak77
Merge pull request joomla#234 from joomla/Elisas-Commits
cdad836 
Elisas commits
richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Apr 3, 2020
@roland-d
Remove the patch chain Fixed joomla#234
ab56101
richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Apr 3, 2020
@roland-d
Cleanup the SQL files joomla#234
d2789bb
hans2103 pushed a commit to hans2103/joomla-cms that referenced this pull request Nov 18, 2020
@richard67
[Metismenu] Horizontal metismenu at other places than the header sect…
7aae429 
…ion and other improvements (joomla#234)

* Add handling of menu-horizontal class to _metismenu.scss

* Simplify CSS

* Fix too much CSS simplification

* Move styling for header section

* Add a css class for menu item level

* Simplify CSS more

* SCSS CS - Fix too deep nesting

* Fix unwanted margin

* Fix dropdown toggle in header

* Distinguish two different types of dropdown toggles

* New template images

* Revert "New template images"

This reverts commit f92f6f701bb9f9170f4e384bdd6775a92d98f1ba.

* RTL fix for dropdown toggle in header

* Add styling for metismenu in footer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanderpotjer @Craiggf @linhos82 @mahagr