-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX][4.0] An error has occurred on Search Filter #23679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Jan 29, 2019
Quy
reviewed
Jan 29, 2019
Co-Authored-By: amitranjan2 <41797766+amitranjan2@users.noreply.github.com>
@Quy I think it's fine now, please review this |
I have tested this item ✅ successfully on f00491a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23679. |
@Quy could you please test this PR ? |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23679. |
@wilsonge if no issue , please merge this |
thx |
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #23677
Summary of Changes
Added
use Joomla\CMS\Language\Text;
use Joomla\CMS\Factory;
use Joomla\CMS\Router\Route;
use Joomla\CMS\Layout\LayoutHelper;
and changed JText to Text
similary to JFactory ,JRoute,JLayoutHelper
Testing Instructions
Components >> smart search >> Search Filters >>New
then write title name and click >> save and close
Expected result
It should be saved and title name should be displaced
Actual result
0 Class 'Text' not found
Documentation Changes Required
NO