Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][4.0] An error has occurred on Search Filter #23679

Merged
merged 28 commits into from
Mar 2, 2019

Conversation

amitranjan2
Copy link
Contributor

Pull Request for Issue #23677

Summary of Changes

Added
use Joomla\CMS\Language\Text;
use Joomla\CMS\Factory;
use Joomla\CMS\Router\Route;
use Joomla\CMS\Layout\LayoutHelper;

and changed JText to Text
similary to JFactory ,JRoute,JLayoutHelper

Testing Instructions

Components >> smart search >> Search Filters >>New
then write title name and click >> save and close

Expected result

It should be saved and title name should be displaced

Actual result

0 Class 'Text' not found

Documentation Changes Required

NO

@amitranjan2
Copy link
Contributor Author

@Quy I think it's fine now, please review this

@anuragteapot
Copy link
Contributor

I have tested this item ✅ successfully on f00491a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23679.

@amitranjan2
Copy link
Contributor Author

@Quy could you please test this PR ?

@Quy
Copy link
Contributor

Quy commented Feb 13, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23679.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 13, 2019
@amitranjan2
Copy link
Contributor Author

@wilsonge if no issue , please merge this

@HLeithner HLeithner merged commit fce8064 into joomla:4.0-dev Mar 2, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 2, 2019
@HLeithner
Copy link
Member

thx

@HLeithner HLeithner added this to the Joomla 4.0 milestone Mar 2, 2019
@amitranjan2
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants