Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exploit #261

Closed
wants to merge 1 commit into from
Closed

fix exploit #261

wants to merge 1 commit into from

Conversation

oc666
Copy link
Contributor

@oc666 oc666 commented Jul 6, 2012

@infograf768
Copy link
Member

We are aware of this and have a patch for next version
Please contact me on skype.

@infograf768 infograf768 closed this Jul 6, 2012
wilsonge pushed a commit to wilsonge/joomla-cms that referenced this pull request Sep 5, 2014
Fix parse function being public in JUri
dneukirchen pushed a commit to dneukirchen/joomla-cms that referenced this pull request Sep 28, 2017
* Update Api.php

Pull Request for Issue joomla#230 .

Summary of Changes

when an uploaded file has spaces it is replace by a underscore (same way for folder creation).
It was done by:
1. moving 'getSafeName' function from the model Api.php to the controller Api.ph
2. Call 'getSafeName' in the controller API in two places: (a) creation of a file or directory, and (b) uploading a new image
3. remove the call of 'getSafeName' in the model

Testing Instructions

try to upload several files with different special characters like spaces, dashes etc.

Expected result

1. Uploaded file and no 403 error

Actual result

I made some tests in "old Joomla (3.7.2), before my changes and after it and swa the following:

1. filename with english latters and one or more spaces
- "old": an error - "Unable to create folder. Folder name must only contain alphanumeric characters and no spaces."
- J4 before the change - 403
- J4 after the change - all spaces are replaced with '_'

2. file name with special charcter (e.g. Hebrew)
- "old": an error - "Unable to create folder. Folder name must only contain alphanumeric characters and no spaces."
- J4 before the change - nothing happens
- J4 after the change - nothing happens

3. directory name with spaces
- "old": an error - "Unable to create folder. Folder name must only contain alphanumeric characters and no spaces."
- J4 before the change - all spaces are replaced with '_'
- J4 after the change - all spaces are replaced with '_'

4. directory with special charcter (e.g. Hebrew)
- "old": an error - "Unable to create folder. Folder name must only contain alphanumeric characters and no spaces."
- J4 before the change - nothing happens
- J4 after the change - nothing happens

* code style error
bembelimen pushed a commit to bembelimen/joomla-cms that referenced this pull request Jul 15, 2019
Responsive header for install template
richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Apr 3, 2020
…-sql

Clean up one more SQL file - most important one - from patchtester chain
richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Nov 30, 2020
* 🎨 code style

* 💄 px => (r)em

* 🎨 code style

* 🐛 fix chevron on mm-toggle-nolink

* 🐛 fix chevron on mm-toggle-nolink

* prevent > 4 nested depth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants