[4.0] Set data directly into state rather than faking a proxy into the input #27696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
force-pushed
the
webservice_state_inject
branch
from
6516c49 to
3d3638b
Compare
wilsonge
changed the title
wilsonge
changed the title
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
I missed in the GSOC project we'd started to store state fullblown in the input object which is obviously wrong. This changes it so we do webservices properly and build a state object to pass into the model. This is a moderate security fix to the unreleased webservices because potentially with this you can inject arbitrary state into the model directly from query parameters which is obviously bad.
Testing Instructions
Affected webservices (e.g. categories) continue to function with no changes from before.
Documentation Changes Required
Yes when webservices are documented