[4.0] Media Manager Events correctly triggered

[dgrammatiko]

Pull Request for Issues #28877 #28878

Summary of Changes

Refactor the Model to trigger the correct Events with the correct payload for files/folders created/updated/deleted

Testing Instructions

Download install and enable the following plugin
mediamanagertest.zip

Test steps:

• Upload a file in the media manager
• Delete the file you just uploaded
• Edit the image you just uploaded, eg crop it
• Create a folder
• Delete the newly created folder

Check plugins/content/mediamanagertest for a file log.txt the contents should be like

File uploaded
-------------------------
Event Type: onContentBeforeSave
Event Payload: {"adapter":"local-0","name":"Screenshot 2020-04-29 at 19.22.58.png","path":"\/","new":true}
-------------------------

-------------------------
Event Type: onContentAfterSave
Event Payload: {"adapter":"local-0","name":"Screenshot 2020-04-29 at 19.22.58.png","path":"\/","new":true}
-------------------------

File updated
-------------------------
Event Type: onContentBeforeSave
Event Payload: {"adapter":"local-0","name":"screenshot 2020-04-29 at 19.22.58.png","path":"\/","new":false}
-------------------------

-------------------------
Event Type: onContentAfterSave
Event Payload: {"adapter":"local-0","name":"screenshot 2020-04-29 at 19.22.58.png","path":"\/","new":false}
-------------------------

File Deleted
-------------------------
Event Type: onContentBeforeDelete
Event Payload: {"data":{"adapter":"local-0","path":"\/screenshot.png"}}
-------------------------

-------------------------
Event Type: onContentAfterDelete
Event Payload: {"data":{"adapter":"local-0","path":"\/screenshot.png"}}
-------------------------

Folder Created
-------------------------
Event Type: onContentBeforeSave
Event Payload: {"adapter":"local-0","name":"test","path":"\/","new":true}
-------------------------

-------------------------
Event Type: onContentAfterSave
Event Payload: {"adapter":"local-0","name":"test","path":"\/","new":true}
-------------------------

Folder Deleted
-------------------------
Event Type: onContentBeforeDelete
Event Payload: {"data":{"adapter":"local-0","path":"\/test"}}
-------------------------

-------------------------
Event Type: onContentAfterDelete
Event Payload: {"data":{"adapter":"local-0","path":"\/test"}}
-------------------------

Expected result

Actual result

Documentation Changes Required

No, bug fix

Remarks:

• Moving/copying files won't trigger any event. This is kinda awkward...

@laoneo @dneukirchen

[SharkyKZ]

Now Media Action - Resize plugin doesn't work.

[dgrammatiko]

Good catch, I guess 45165a5 should fix that

[infograf768]

Is that also spposed to solve #28842

[dgrammatiko]

@infograf768 partly.

Also, internal server error when saving name of file or folder.

This should be ok now. Reason was that one of the current events had a wrong signature (expected to be called with 4 params but was called with 3)

[laoneo]

Not sure but we returned here the name attribute of the object because plugins could change it during the event.

[dgrammatiko]

Good catch, I'll change that

[infograf768]

Ref: #28886 (comment) & #28842 (comment)
I still get the Internal Server Error when saving the file with the same name. It's OK when modifying the name of the file.

[dgrammatiko]

I still get the Internal Server Error when saving the file with the same name

Sorry I misunderstood, I was talking about renaming to something different.

[infograf768]

Still wrong.

[adj9]

I have not tested this item.

@dgrammatiko I installed the plugin and function. Subsequently I looked for the log.txt file that you describe, but I did not find it .... I only have the indication of User Action Log. Where is the file?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28886.}

[dgrammatiko]

I looked for the log.txt

it is created in the plugin's folder: plugins/content/mediamanagertest

[adj9]

Apply PR it all worked out. Going to Latest actions (from home dashboard) and clicking on the name of the uploaded image, I have error 0

[dgrammatiko]

@adj9 I think that's ok as the plugin is a dummy implementation to showcase that the events are triggered correctly, in other words it doesn't actually do what it was supposed to do

[alikon]

so it's only a problem related to the com_actionlogs ?

[dgrammatiko]

@alikon do components require special code to trigger anything for the com_actionlogs?
If so then someone needs to patch the media manager to support that but that's out of the scope of this PR

[alikon]

I have tested this item ✅ successfully on 5b27cf6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28886.}

[Quy]

I have tested this item ✅ successfully on 5b27cf6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28886.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28886.}

[wilsonge]

Thanks!