Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] com_mails: string typo & template fields labels display missing #29224

Merged
merged 2 commits into from
May 26, 2020

Conversation

infograf768
Copy link
Member

Pull Request for Issue #28722 (comment)

Summary of Changes

  1. This corrects the language string by taking off when to get
    COM_USERS_MAIL_REMINDER_DESC="This mail is sent to a user by the \"Forgot your username?\" link e.g. in a login form." Can be seen on review.

  2. It also corrects the template edit missing labels for the switchers.

Testing Instructions

Display for example index.php?option=com_mails&view=template&layout=edit&template_id=com_config.test_mail&language=fr-FR [Choose any language]

Before patch

Screen Shot 2020-05-26 at 11 04 35

After patch

Screen Shot 2020-05-26 at 10 57 02

@toivo
Copy link
Contributor

toivo commented May 26, 2020

I have tested this item ✅ successfully on ab7d723

Tested successfully in Nightly Build of 26 May.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29224.

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@richard67
Copy link
Member

I have tested this item ✅ successfully on 409acff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29224.

@infograf768
Copy link
Member Author

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29224.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 26, 2020
@richard67
Copy link
Member

Restored @toivo 's test result because last change was only a small correction of the language string.

@Quy Quy added this to the Joomla 4.0 milestone May 26, 2020
@Quy Quy merged commit 8d70f4a into joomla:4.0-dev May 26, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 26, 2020
@infograf768 infograf768 deleted the 4.0_com_mails_errors branch May 26, 2020 13:57
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
…joomla#29224)

* [4.0] com_mails: string typo & template fields labels display missing

* Update administrator/language/en-GB/com_users.ini

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants