[4.0] Fix HTML body editing for mail templates #29229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #28524 .
Summary of Changes
Add missing enable/disable of the input for the HTML body to the javascript for Mail Templates admin edit, like it is already there for the input for the (text) body.
Testing Instructions
Preparation
For reproducing the issue you have to use a clean 4.0-dev staging branch or latest J4 nightly build.
For testing the patch of this Pull Request (PR) here, you have to do following 2 steps:
npm ci
ornpm run build:js
.If you don't have npm, make a new installation with the installation package build for this PR, and then test. No need to apply the patch in this case, the patch is already included. You can find the installation package here: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/29229/downloads/32398/
Execution
Expected result with patch applied
You can add an HTML body for an email template, and it's not lost after saving.
You can add replacement tags to the HTML body of an email template.
You can toggle the editor.
Actual result without patch applied
You can't save an HTML body for an email template, see issue #28524 .
You can't add replacement tags to the HTML body of an email template.
You can't really toggle the editor.
Documentation Changes Required
None, except if we have some documentation telling that the above shall not work ;-)