Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix HTML body editing for mail templates #29229

Merged

Conversation

richard67
Copy link
Member

@richard67 richard67 commented May 26, 2020

Pull Request for Issue #28524 .

Summary of Changes

Add missing enable/disable of the input for the HTML body to the javascript for Mail Templates admin edit, like it is already there for the input for the (text) body.

Testing Instructions

Preparation

For reproducing the issue you have to use a clean 4.0-dev staging branch or latest J4 nightly build.

For testing the patch of this Pull Request (PR) here, you have to do following 2 steps:

  1. Apply the patch e.g. with patchtester on a clean 4.0-dev staging branch or latest J4 nightly build.
  2. Run npm ci or npm run build:js.

If you don't have npm, make a new installation with the installation package build for this PR, and then test. No need to apply the patch in this case, the patch is already included. You can find the installation package here: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/29229/downloads/32398/

Execution

  1. See issue [4.0] Impossible to save an Email Template in a HTML Format #28524 : Check if you can add an HTML body to a mail template. Check that the HTML body is not lost after saving.
  2. Try to toggle the editor.
  3. Try to insert into the HTML body some of the replacement tags shown right beside the editor.

Expected result with patch applied

You can add an HTML body for an email template, and it's not lost after saving.

You can add replacement tags to the HTML body of an email template.

You can toggle the editor.

Actual result without patch applied

You can't save an HTML body for an email template, see issue #28524 .

You can't add replacement tags to the HTML body of an email template.

You can't really toggle the editor.

Documentation Changes Required

None, except if we have some documentation telling that the above shall not work ;-)

@richard67
Copy link
Member Author

Adding release blocker label as inherited by the referenced issue.

@wilsonge wilsonge merged commit bbe073c into joomla:4.0-dev May 26, 2020
@wilsonge
Copy link
Contributor

LGTM! Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone May 26, 2020
@richard67
Copy link
Member Author

😄

@richard67 richard67 deleted the 4.0-dev-fix-mail-templates-html-body-1 branch May 26, 2020 14:21
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants