-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Remove margin between accordion slides #29579
Conversation
I have a B/C problem here with com_localise after this patch.
Then I have another accordeon + slide.
Before this PR |
I can evidently solve it by adding the mb-2 class to the div enclosing this template but I wonder if this PR is the correct solution.
|
I have tested this item ✅ successfully on 878e3bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29579. |
I have tested this item ✅ successfully on 878e3bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29579. |
rtc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29579. |
Thanks all! |
@ceford Yes, that's expected. @infograf768 you can also pass This PR is fine in that it fixes the default styling. Before patch, this looked fine in Atum because it has custom CSS but not in Cassiopeia or in any stock Bootstrap template. |
* Remove margin between accordion slides * Add margin to field
Fixes #29311.
Summary of Changes
Removes margin between Bootstrap accordion slides.
Testing Instructions
Edit a module in frontend.
Expected result
Looks OK.
Actual result
Gap between slides and first slide is missing the bottom border:
Documentation Changes Required
No.