[4.0] Fix for AccessibleMediaField #29840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
approved these changes
Jun 29, 2020
Quy
reviewed
Jun 30, 2020
tests/Unit/Libraries/Cms/Form/Field/AccessiblemediaFieldTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Quy <quy@fluxbb.org>
|
I have tested this item ✅ successfully on 62c45d2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29840. |
|
The API Value allows you to override the value returned by the API application. Nothing more. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # #29825.
Summary of Changes
If the
accessiblemediafield within in asubfield,valueis an objectstdClass. I extended the check for this. Also, I added the unit tests for the field and do not use$field->apivalueany more because the name is misleading and it is not possible in asubfieldcustom field.Testing Instructions
Please test like explained here: [4.0] Media fields accessibility - second try #27712
Please also check whether the media custom field can be used within a subform custom field. Note: If you insert the media custom field in a subform custom field, you can only select (when editing the article) an image file after you have saved the article. This issue is not related to this PR. Please see [4.0] TypeError: this.querySelector(...).open is not a functionjoomla-field-media.js:244:45 #26711.
Check also the rendering in the front end for the custom field of type
mediaandsubfield incluing media field.Documentation Changes Required
Yes