Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing string when uploading files #30671

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Missing string when uploading files #30671

merged 1 commit into from
Sep 18, 2020

Conversation

SharkyKZ
Copy link
Contributor

Summary of Changes

Remove com_media string as we have an identical global string.
Use global string in filesystem plugin.

Testing Instructions

Try to upload a file with allowed extension but disallowed MIME type.

Actual result BEFORE applying this Pull Request

Untranslated error message:

COM_MEDIA_ERROR_UNABLE_TO_UPLOAD_FILE

Expected result AFTER applying this Pull Request

Translated error message:

Unable to upload file.

Documentation Changes Required

No.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 4f1b87e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30671.

1 similar comment
@ghost
Copy link

ghost commented Sep 18, 2020

I have tested this item ✅ successfully on 4f1b87e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30671.

@infograf768 infograf768 removed Language Change This is for Translators PR-4.0-dev labels Sep 18, 2020
@infograf768
Copy link
Member

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30671.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 18, 2020
@richard67 richard67 added Language Change This is for Translators PR-4.0-dev labels Sep 18, 2020
@infograf768 infograf768 merged commit 0fcdf47 into joomla:4.0-dev Sep 18, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 18, 2020
@infograf768 infograf768 added this to the Joomla 4.0 milestone Sep 18, 2020
@SharkyKZ SharkyKZ deleted the j4/string/media-upload branch September 18, 2020 07:58
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
heelc29 added a commit to heelc29/joomla that referenced this pull request Sep 13, 2024
joomla/joomla-cms#30671
joomlagerman/joomla1090
heelc29 added a commit to heelc29/joomla that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants