-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] Add prebuilt packages for 4.1-dev #30845
Conversation
We will need to sign this change but I will see if it works first, I'm not sure if the compile script can handle this version without modifications |
As I thought we have to update the packager first. Adding the update template for 4.1-dev and update the packing script to support 4.1-dev |
Finally, does this PR also make it possible to download Joomla 4.1 from the Nightly Builds? |
i'm sorry no, this will allow when it will work to have a prebuild dowload package for pr against the 4.1-dev branch, like you currently have for pr against staging and 4.0-dev |
Thefore we need to setup a jenkins task and update Developer this is not something to be done in the cms repo |
I assume that for testing these prebuild dowload packages, it is required to test in Joomla! 4.1 anyway. |
not exactly the prebuild package will come with all in place to test a pr with 4-1.dev, ie 4.1-dev+pr, like we already have for staging and for 4.0-dev it's an alternative way to test a pr without for example com_patchtester, nightly builds is another thing |
PR for the update server has been added here: joomla-projects/docker-images#30 and the branch version has been bumped here: 66573c9 So once that packager PR is deployed and this branch updated this should be OK i guess. cc @HLeithner |
@alikon please use this signature: df68dcf150bfb9093f6f8506f631a86ecaf5a62b25e486558abd721cf94c9082 |
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HLeithner please review & merge
thanks |
same as #28409 for 4.0-dev or #28594 for staging but for 4.1-dev
Actual result BEFORE applying this Pull Request
no prebuilt packages for 4.1-dev
Expected result AFTER applying this Pull Request
prebuilt packages for pr's on 4.1-dev