Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Add prebuilt packages for 4.1-dev #30845

Merged
merged 5 commits into from
Oct 4, 2020
Merged

[4.1] Add prebuilt packages for 4.1-dev #30845

merged 5 commits into from
Oct 4, 2020

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Oct 1, 2020

same as #28409 for 4.0-dev or #28594 for staging but for 4.1-dev

Actual result BEFORE applying this Pull Request

no prebuilt packages for 4.1-dev

Expected result AFTER applying this Pull Request

prebuilt packages for pr's on 4.1-dev

@HLeithner
Copy link
Member

We will need to sign this change but I will see if it works first, I'm not sure if the compile script can handle this version without modifications

@HLeithner
Copy link
Member

As I thought we have to update the packager first. Adding the update template for 4.1-dev and update the packing script to support 4.1-dev

@sandewt
Copy link
Contributor

sandewt commented Oct 3, 2020

Finally, does this PR also make it possible to download Joomla 4.1 from the Nightly Builds?

@alikon
Copy link
Contributor Author

alikon commented Oct 3, 2020

i'm sorry no, this will allow when it will work to have a prebuild dowload package for pr against the 4.1-dev branch, like you currently have for pr against staging and 4.0-dev

@alikon alikon marked this pull request as draft October 3, 2020 10:54
@zero-24
Copy link
Contributor

zero-24 commented Oct 3, 2020

Finally, does this PR also make it possible to download Joomla 4.1 from the Nightly Builds?

Thefore we need to setup a jenkins task and update Developer this is not something to be done in the cms repo

@sandewt
Copy link
Contributor

sandewt commented Oct 3, 2020

I assume that for testing these prebuild dowload packages, it is required to test in Joomla! 4.1 anyway.
I think many will drop out if no download is available from Nightly builds.

@alikon
Copy link
Contributor Author

alikon commented Oct 3, 2020

not exactly the prebuild package will come with all in place to test a pr with 4-1.dev, ie 4.1-dev+pr, like we already have for staging and for 4.0-dev it's an alternative way to test a pr without for example com_patchtester, nightly builds is another thing

@zero-24
Copy link
Contributor

zero-24 commented Oct 3, 2020

PR for the update server has been added here: joomla-projects/docker-images#30 and the branch version has been bumped here: 66573c9

So once that packager PR is deployed and this branch updated this should be OK i guess. cc @HLeithner

@alikon alikon marked this pull request as ready for review October 4, 2020 05:42
@zero-24
Copy link
Contributor

zero-24 commented Oct 4, 2020

@alikon please use this signature: df68dcf150bfb9093f6f8506f631a86ecaf5a62b25e486558abd721cf94c9082

alikon and others added 2 commits October 4, 2020 09:14
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Copy link
Contributor

@zero-24 zero-24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HLeithner please review & merge

@HLeithner HLeithner merged commit 12d2aa9 into joomla:4.1-dev Oct 4, 2020
@HLeithner
Copy link
Member

thanks

@HLeithner HLeithner added this to the Joomla 4.1 milestone Oct 4, 2020
@alikon alikon deleted the patch-81 branch October 4, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants