Manager for Language Overrides #31

Chraneco · 2011-12-06T20:55:21Z

Hi,

while supporting our component we come often across people who want to change the language output.
It has to be explained then in which file the string can be found so that it can be edited.

With the new version of Joomla! it is possible to create language overrides so that the changes aren't lost anymore during the updates. This is great, but the user still has to find the correct language file in order to detect which language constant he has to override.

With this pull request I'd like to suggest a new manager which simplifies that.
It's a new tab in language manager in which users can create language overrides for any installed language.

In the edit view a search can be done for language strings the user wants to change. The script will then take completely care of the override.ini files.

This way people can change any language output of their site without having to know anything about language constants or override.ini files.

Please let me know what you think about that.

Regards
Chraneco

infograf768 · 2011-12-07T06:37:35Z

Please add this proposal in the Feature Tracker with the .diff as a file. Thanks.

infograf768 · 2011-12-07T07:52:28Z

hello,

I like the idea. Would be a good addition. :)
I tested your patch:

Remarks:

Post the proposal as a patch in the feature tracker with
instructions of use (i.e. create the new table, etc.)
You are modifying /media/system/js/mootools-core-uncompressed.js
and I guess this is an oversight.
"Search text you want to change" is not working here
Not standard coding

regards
JM

Hi,

while supporting our component we come often across people who want
to change the language output.
It has to be explained then in which file the string can be found so
that it can be edited.

With the new version of Joomla! it is possible to create language
overrides so that the changes aren't lost anymore during the
updates. This is great, but the user still has to find the correct
language file in order to detect which language constant he has to
override.

With this pull request I'd like to suggest a new manager which
simplifies that.
It's a new tab in language manager in which users can create
language overrides for any installed language.

In the edit view a search can be done for language strings the user
wants to change. The script will then take completely care of the
override.ini files.

This way people can change any language output of their site without
having to know anything about language constants or override.ini
files.

Please let me know what you think about that.

Regards
Chraneco

You can merge this Pull Request by running:

git pull https://github.com/Chraneco/joomla-cms master

Or you can view, comment on it, or merge it online at:

#31

-- Commit Summary --

Initial Commit for Language Overrides Manager

Merge remote-tracking branch 'upstream/master'

Clean up - Small improvements - Code Style

Accidentally commited file removed

'No Results' message added

-- File Changes --

A administrator/components/com_languages/controllers/override.php (200)
A administrator/components/com_languages/controllers/overrides.php (69)
A administrator/components/com_languages/controllers/strings.json.php (63)
A administrator/components/com_languages/helpers/jsonresponse.php (127)
M administrator/components/com_languages/helpers/languages.php (97)
A administrator/components/com_languages/models/forms/override.xml (37)
A administrator/components/com_languages/models/override.php (168)
A administrator/components/com_languages/models/overrides.php (205)
A administrator/components/com_languages/models/strings.php (162)
M
administrator/components/com_languages/views/installed/tmpl/default_navigation.php
(2)
A administrator/components/com_languages/views/override/index.html (1)
A administrator/components/com_languages/views/override/tmpl/edit.php (88)
A administrator/components/com_languages/views/override/tmpl/index.html (1)
A administrator/components/com_languages/views/override/view.html.php (132)
A administrator/components/com_languages/views/overrides/index.html (1)
A administrator/components/com_languages/views/overrides/tmpl/default.php (99)
A administrator/components/com_languages/views/overrides/tmpl/index.html (1)
A administrator/components/com_languages/views/overrides/view.html.php (112)
M administrator/language/en-GB/en-GB.com_languages.ini (30)
M installation/sql/mysql/joomla.sql (15)
A media/overrider/css/index.html (1)
A media/overrider/css/overrider.css (53)
A media/overrider/index.html (1)
A media/overrider/js/index.html (1)
A media/overrider/js/overrider.js (199)
M media/system/js/mootools-core-uncompressed.js (2)

-- Patch Links --

https://github.com/joomla/joomla-cms/pull/31.patch
https://github.com/joomla/joomla-cms/pull/31.diff

Reply to this email directly or view it on GitHub:
#31

Please keep the Subject wording in your answers
This e-mail and any attachments may be confidential. You must not
disclose or use the information contained in this e-mail if you are
not the
intended recipient. If you have received this e-mail in error, please

notify us immediately and delete the e-mail and all copies.

Jean-Marie Simonet / infograf768
Joomla Production Working group
Joomla! Translation Coordination Team

front of one function

Chraneco · 2011-12-08T13:07:18Z

Hi,

thank you very much for your feedback.

Post the proposal as a patch in the feature tracker with instructions of use (i.e. create the new table, etc.)

The created tracker item can be found here:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27320

Hopefully I created the patch file correctly (I'm new to Github)

One new database table has to be created additionally:
CREATE TABLE IF NOT EXISTS #__overrider (
id int(10) NOT NULL AUTO_INCREMENT COMMENT 'Primary Key',
constant varchar(255) NOT NULL,
string text NOT NULL,
file varchar(255) NOT NULL,
PRIMARY KEY (id)
) DEFAULT CHARSET=utf8;

You are modifying /media/system/js/mootools-core-uncompressed.js and I guess this is an oversight.

Sorry, this was indeed unintentional, I reverted it.

"Search text you want to change" is not working here

This may have several causes:

A JavaScript error occured. Hopefully this is solved with my last commits. I tested it with Firefox 8, Opera 11.60, Safari 5.1.2 and Internet Explorer 9 so far.
The database table didn't exist (I should have mentioned that there's a new one).
An SQL error occured. With commit d447c14 the third argument '), (' for instantiating JDatabaseQueryElement (line 1165) in method 'values' of file 'databasequery.php' was removed. I think the method 'values' cannot be used as usual anymore due to that. As a workaround I create one of the queries in model 'strings.php' manually now (without using JDatabaseQuery).

Not standard coding

Do you mean the code style?
I tried to apply that code style guide:
http://developer.joomla.org/standards/
but I guess it holds only for the platform?

Which style guide do I have to use?

Regards
Chraneco

dextercowley · 2011-12-08T18:19:53Z

Hi. If you haven't done so, please add an issue in the Feature Tracker
here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549.
Thanks! Mark Dexter

On Tue, Dec 6, 2011 at 12:55 PM, Chraneco
reply@reply.github.com
wrote:

Hi,

while supporting our component we come often across people who want to change the language output.
It has to be explained then in which file the string can be found so that it can be edited.

With the new version of Joomla! it is possible to create language overrides so that the changes aren't lost anymore during the updates. This is great, but the user still has to find the correct language file in order to detect which language constant he has to override.

With this pull request I'd like to suggest a new manager which simplifies that.
It's a new tab in language manager in which users can create language overrides for any installed language.

In the edit view a search can be done for language strings the user wants to change. The script will then take completely care of the override.ini files.

This way people can change any language output of their site without having to know anything about language constants or override.ini files.

Please let me know what you think about that.

Regards
Chraneco

You can merge this Pull Request by running:

git pull https://github.com/Chraneco/joomla-cms master

Or you can view, comment on it, or merge it online at:

#31

-- Commit Summary --

Initial Commit for Language Overrides Manager

Merge remote-tracking branch 'upstream/master'

Clean up - Small improvements - Code Style

Accidentally commited file removed

'No Results' message added

-- File Changes --

A administrator/components/com_languages/controllers/override.php (200)
A administrator/components/com_languages/controllers/overrides.php (69)
A administrator/components/com_languages/controllers/strings.json.php (63)
A administrator/components/com_languages/helpers/jsonresponse.php (127)
M administrator/components/com_languages/helpers/languages.php (97)
A administrator/components/com_languages/models/forms/override.xml (37)
A administrator/components/com_languages/models/override.php (168)
A administrator/components/com_languages/models/overrides.php (205)
A administrator/components/com_languages/models/strings.php (162)
M administrator/components/com_languages/views/installed/tmpl/default_navigation.php (2)
A administrator/components/com_languages/views/override/index.html (1)
A administrator/components/com_languages/views/override/tmpl/edit.php (88)
A administrator/components/com_languages/views/override/tmpl/index.html (1)
A administrator/components/com_languages/views/override/view.html.php (132)
A administrator/components/com_languages/views/overrides/index.html (1)
A administrator/components/com_languages/views/overrides/tmpl/default.php (99)
A administrator/components/com_languages/views/overrides/tmpl/index.html (1)
A administrator/components/com_languages/views/overrides/view.html.php (112)
M administrator/language/en-GB/en-GB.com_languages.ini (30)
M installation/sql/mysql/joomla.sql (15)
A media/overrider/css/index.html (1)
A media/overrider/css/overrider.css (53)
A media/overrider/index.html (1)
A media/overrider/js/index.html (1)
A media/overrider/js/overrider.js (199)
M media/system/js/mootools-core-uncompressed.js (2)

-- Patch Links --

https://github.com/joomla/joomla-cms/pull/31.patch
https://github.com/joomla/joomla-cms/pull/31.diff

Reply to this email directly or view it on GitHub:
#31

Chraneco · 2011-12-08T21:14:57Z

Hi,

I already handed the link in with my second post above, but here it is again for completeness:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27320

Regards
Chraneco

infograf768 · 2011-12-09T08:25:22Z

Going on now the discussion on tracker

elinw · 2011-12-10T14:47:45Z

WOuld you send a pull request to https://github.com/elinw/joomla-cms/tree/pbf2011 please so it can be tested in pbf.

Chraneco · 2011-12-10T14:55:25Z

Hi,

I'm not sure how to do that (I'm new to Github).
If I click on 'Pull Request' it wants to edit the current pull request rather than create a new one for another branch.

Shall I simply change it to yours?

Regards
Chraneco

mbabker · 2011-12-10T15:11:23Z

@Chraneco leave it as is. I'll merge your pull request into my local check out and issue the merge request (it'll keep your history, just a couple of merge commits on top).

Chraneco · 2011-12-10T16:45:42Z

Thank you very much!

work anymore

Cleaned up After JVersion Rename

…anged

* Initial test environment setup with Jasmine, Karma and RequireJS * Seperated test setup code from test logic * Configured .travis.yml to run Karma * Fixed typo in .travis.yml * changes to .travis.yml * Added karma requirejs module * Removed unnecessary code in travis.yml * Fixed missing code is travis.yml * Removed 2 unused image files * Improved code standards * Modified travis.yml * Issue 1 Cleaned the mess with changes bunch of to unrelated files * Issue 1 Added newline at end of file * Issue 4 Improved JCaption JavaScript tests * New coeverage reporter plugin test with Travis * Issue 1 Added karma-coerage reporter and configured it to display coverage on console * Issue 1 Added and configured karma-verbose-reporter plugin * Issue 1 Fixing verbose reporter config for travis * Issue 1 removed redundant javascript dir and added requirejs/text plugin to load fixtures * Issue 4 Improved code with suggestions made in the code review * Issue 1 Added version for requirejs text plugin * Issue 1 converted space indentations to tabs * Issue 1 Fixed indentation in package.json * Issue 1 Fixed version issue in require text * Issue 1 Fixed version issue in require text * Issue 1 Fixed version issue in require text * Issue 4 Improved code standards and jquer selector efficiency * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Removed spec folder * Corejs tests (#15) Tests for core.js * Tests for permissions.js (#13) * Test suite for permissions.js * Added karma-jasmine-ajax plugin * Added a container div for fixtures representing library name (#11) * Added a container div for fixtures representing the library name * CS - Removed an extra new line * Permissions.js tests Test for permissions * Repeatable.js test suite * Improvements to JCaption tests * README.md update * Modified readme file * Made running tests easier by adding configuration for tests to run on npm test * Core js Improvements * Issue 9 Added jasmine spies and improved code * Issue 9 Fixed an indentation issue * Demo video on Youtube * Inserted the video demonstration link to the readme * Issue 5 Added spies and made code improvements (#31) * Issue 12 Improved code (#34) * Repeatable.js Improvements (#35) * Run Travis JavaScript tests on separated Matrix Build (#39) * Only run Travis tests on PHP 7 * Fix base path issue * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Reverted README.md * Synced README.md to the new version * Synced README.md with new version * Fixed indentations * Synced README.md with 3.6 version * Fixed indentations * Fixed indentations * Added newline at the end of travis-tests.sh * Added missing sudo:false in .travis.yml

* Initial test environment setup with Jasmine, Karma and RequireJS * Seperated test setup code from test logic * Configured .travis.yml to run Karma * Fixed typo in .travis.yml * changes to .travis.yml * Added karma requirejs module * Removed unnecessary code in travis.yml * Fixed missing code is travis.yml * Removed 2 unused image files * Improved code standards * Modified travis.yml * Issue 1 Cleaned the mess with changes bunch of to unrelated files * Issue 1 Added newline at end of file * Issue 4 Improved JCaption JavaScript tests * New coeverage reporter plugin test with Travis * Issue 1 Added karma-coerage reporter and configured it to display coverage on console * Issue 1 Added and configured karma-verbose-reporter plugin * Issue 1 Fixing verbose reporter config for travis * Issue 1 removed redundant javascript dir and added requirejs/text plugin to load fixtures * Issue 4 Improved code with suggestions made in the code review * Issue 1 Added version for requirejs text plugin * Issue 1 converted space indentations to tabs * Issue 1 Fixed indentation in package.json * Issue 1 Fixed version issue in require text * Issue 1 Fixed version issue in require text * Issue 1 Fixed version issue in require text * Issue 4 Improved code standards and jquer selector efficiency * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Removed spec folder * Corejs tests (joomla#15) Tests for core.js * Tests for permissions.js (#13) * Test suite for permissions.js * Added karma-jasmine-ajax plugin * Added a container div for fixtures representing library name (#11) * Added a container div for fixtures representing the library name * CS - Removed an extra new line * Permissions.js tests Test for permissions * Repeatable.js test suite * Improvements to JCaption tests * README.md update * Modified readme file * Made running tests easier by adding configuration for tests to run on npm test * Core js Improvements * Issue 9 Added jasmine spies and improved code * Issue 9 Fixed an indentation issue * Demo video on Youtube * Inserted the video demonstration link to the readme * Issue 5 Added spies and made code improvements (joomla#31) * Issue 12 Improved code (joomla#34) * Repeatable.js Improvements (joomla#35) * Run Travis JavaScript tests on separated Matrix Build (joomla#39) * Only run Travis tests on PHP 7 * Fix base path issue * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Reverted README.md * Synced README.md to the new version * Synced README.md with new version * Fixed indentations * Synced README.md with 3.6 version * Fixed indentations * Fixed indentations * Added newline at the end of travis-tests.sh * Added missing sudo:false in .travis.yml

@wojsmol

* codestyle * code style * codestyle * codestyle * codestyle * thanks @wojsmol * corrections - thanks @Quy * corrections - thanks @Quy * oops * make @Quy happy * Update article.xml * Remove space * Update config.xml (#14) * Update filter.xml (#15) * Update config.xml (#16) * Update profile.xml (#17) * Update application.xml (#18) * Update article.xml (#19) * Update filter_articles.xml (#20) * Update config.xml (#24) * Update config.xml (#23) * Update filter_fields.xml (#22) * Update filter_featured.xml (#21) * Update override.xml (#25) * Update config.xml * Update config.xml (#26) * Update itemadmin_alias.xml (#30) * Update itemadmin.xml (#29) * Update item.xml (#27) * Update item_alias.xml (#28) * Update itemadmin_url.xml (#31) * Update module.xml (#32) * Update plugin.xml (#33) * Update config.xml (#34) * Update link.xml (#35) * Update config.xml (#36) * Update style.xml (#38) * Update config.xml (#37) * Update note.xml (#42) * Update group.xml (#41) * Update filter_debuggroup.xml (#40) * Update config.xml (#39) * corrections for @andrepereiradasilva * gotya

Updating installation script

Revert back to cancelTour as of cypress PR joomla#31

Chraneco added 5 commits December 2, 2011 10:49

Initial Commit for Language Overrides Manager

0a56caa

Merge remote-tracking branch 'upstream/master'

aabb258

Clean up - Small improvements - Code Style

ac704aa

Accidentally commited file removed

6436ed1

'No Results' message added

bd40599

Chraneco added 4 commits December 8, 2011 08:28

Undesired change in Mootools reverted - Key word static was missing in

d8c945b

front of one function

Merge remote-tracking branch 'upstream/master'

3ba5e01

Clean Up - Small Improvements

c69156c

JavaScript Error in Internet Explorer

4de201b

Chraneco added 5 commits December 10, 2011 06:54

Code Style - Small Improvements and additions

4d42ff9

Button in edit view removed, description added, display of file added

ee3ce77

Code style improvement

2d2e100

Merge remote-tracking branch 'upstream/master'

71490d5

PHP notice while storing an entry

f56b019

Chraneco added 3 commits December 11, 2011 18:25

Two filter boxes merged into one - Style improved

9a5b3f0

Merge remote-tracking branch 'upstream/master'

635b4b1

Use default frontend language as default filter - Pagination did not

cb5e792

work anymore

elinw referenced this pull request in elinw/joomla-cms Dec 11, 2011

Merge pull request #31 from Paladin/JVersion

0c62858

Cleaned up After JVersion Rename

Chraneco added 2 commits December 12, 2011 15:30

Try to translate select box contents only once

ae23787

Merge remote-tracking branch 'upstream/master'

3b939c6

Chraneco added 4 commits December 14, 2011 14:11

Possibility to select search type ('constant', 'value', 'file')

2cb6f8a

Merge remote-tracking branch 'upstream/master'

5686deb

Removing third search type 'file' again

e6d6661

Go on using the same search string with 'more' link even if it was ch…

3d90270

…anged

chdemko closed this Jan 18, 2012

Ruchiranga added a commit to Ruchiranga/joomla-cms that referenced this pull request Aug 3, 2016

Issue 5 Added spies and made code improvements (joomla#31)

4bd2191

richard67 referenced this pull request in richard67/joomla-cms Apr 3, 2020

Merge pull request #31 from obsidev/patch-1

e807743

Updating installation script

obuisard added a commit to obuisard/joomla-cms that referenced this pull request Aug 7, 2024

Update Installation.cy.js

a93dfea

Revert back to cancelTour as of cypress PR joomla#31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manager for Language Overrides #31

Manager for Language Overrides #31

Chraneco commented Dec 6, 2011

infograf768 commented Dec 7, 2011

infograf768 commented Dec 7, 2011

notify us immediately and delete the e-mail and all copies.

Chraneco commented Dec 8, 2011

dextercowley commented Dec 8, 2011

Chraneco commented Dec 8, 2011

infograf768 commented Dec 9, 2011

elinw commented Dec 10, 2011

Chraneco commented Dec 10, 2011

mbabker commented Dec 10, 2011

Chraneco commented Dec 10, 2011

Manager for Language Overrides #31

Manager for Language Overrides #31

Conversation

Chraneco commented Dec 6, 2011

infograf768 commented Dec 7, 2011

infograf768 commented Dec 7, 2011

notify us immediately and delete the e-mail and all copies.

Chraneco commented Dec 8, 2011

dextercowley commented Dec 8, 2011

Chraneco commented Dec 8, 2011

infograf768 commented Dec 9, 2011

elinw commented Dec 10, 2011

Chraneco commented Dec 10, 2011

mbabker commented Dec 10, 2011

Chraneco commented Dec 10, 2011