[4.0] Fix broken Joomla manifest and therefore broken Joomla Update check caused by recently merged PR #31504 #31525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nibra For your information. |
|
Could also be merged by review. |
|
Thanks |
|
Welcome ;-) |
|
Thanks - beat me to it |
|
Thank you, @richard67, just checked: You found the only occurance. |
@nibra You can be sure that I've checked this, too, |
|
At least we were consistent from the merge into 3.10 #30371 :D |
|
Oh, that's so long ago, I even have forgotten about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Fixes broken closing tag for copyright in Joomla manifest caused by recently merged PR #31504 .
Testing Instructions
Install current 4.0-dev or latest nightly, go to backend switch error reporting to "Maximum".
Then wait for the Joomla Update check to complete.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No such stuff, only nice green buttons.
Documentation Changes Required
None.