Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3][com_postinstall] warning on php 8 #31537

Merged
merged 4 commits into from
Dec 4, 2020
Merged

[3][com_postinstall] warning on php 8 #31537

merged 4 commits into from
Dec 4, 2020

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Nov 30, 2020

Pull Request for Issue #31483 .

Summary of Changes

php 8 compatibility

Testing Instructions

use php 8
go to Admin->Control Panel

Actual result BEFORE applying this Pull Request

Warning: FOFModelBehavior::onBeforeBuildQuery(): Argument #1 ($model) must be passed by reference, value given in \libraries\fof\utils\observable\event.php on line 63

Expected result AFTER applying this Pull Request

no warning

@810
Copy link
Contributor

810 commented Nov 30, 2020

I have tested this item ✅ successfully on e050d05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537.

1 similar comment
@ghost
Copy link

ghost commented Dec 1, 2020

I have tested this item ✅ successfully on e050d05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537.

@joomla-cms-bot joomla-cms-bot removed PHP 8.x PHP 8.x deprecated issues PR-staging labels Dec 1, 2020
@alikon
Copy link
Contributor Author

alikon commented Dec 1, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 1, 2020
@richard67 richard67 added PHP 8.x PHP 8.x deprecated issues PR-staging labels Dec 1, 2020
@jameswadsworth
Copy link

I have tested this item ✅ successfully on e050d05

This resolves the issue in php 7.4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537.

@HLeithner
Copy link
Member

can you please add the modified doc block to both files?

* @note This file has been modified by the Joomla! Project and no longer reflects the original work of its author.

@HLeithner HLeithner added this to the Joomla! 3.9.24 milestone Dec 4, 2020
@alikon
Copy link
Contributor Author

alikon commented Dec 4, 2020

yes, done

@HLeithner HLeithner merged commit 3448c43 into joomla:staging Dec 4, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 4, 2020
@alikon alikon deleted the patch-130 branch December 4, 2020 18:52
@SharkyKZ
Copy link
Contributor

SharkyKZ commented Dec 4, 2020

This shouldn't have been merged.

@Fedik
Copy link
Member

Fedik commented Dec 6, 2020

@SharkyKZ what alternative for this can be?

@Fedik
Copy link
Member

Fedik commented Dec 6, 2020

but I agree with @SharkyKZ , the changes here will lead to Fatal Error to whose extend the class, with error
Declaration of ' ' must be compatible with ' '

Fedik added a commit to Fedik/joomla-cms that referenced this pull request Dec 6, 2020
@Fedik
Copy link
Member

Fedik commented Dec 6, 2020

I have revert it, and made a better fix, please test #31600

@HLeithner
Copy link
Member

@810 can you test the new version of this pr at #31600 please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants