-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3][com_postinstall] warning on php 8 #31537
Conversation
I have tested this item ✅ successfully on e050d05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537. |
1 similar comment
I have tested this item ✅ successfully on e050d05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537. |
I have tested this item ✅ successfully on e050d05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537. |
can you please add the modified doc block to both files?
|
yes, done |
Thanks |
This shouldn't have been merged. |
@SharkyKZ what alternative for this can be? |
but I agree with @SharkyKZ , the changes here will lead to Fatal Error to whose extend the class, with error |
I have revert it, and made a better fix, please test #31600 |
Pull Request for Issue #31483 .
Summary of Changes
php 8 compatibility
Testing Instructions
use php 8
go to Admin->Control Panel
Actual result BEFORE applying this Pull Request
Warning: FOFModelBehavior::onBeforeBuildQuery(): Argument #1 ($model) must be passed by reference, value given in \libraries\fof\utils\observable\event.php on line 63
Expected result AFTER applying this Pull Request
no warning