Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bootstrap 5 #32037

Merged
merged 100 commits into from
Jan 22, 2021
Merged
Show file tree
Hide file tree
Changes from 76 commits
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
744402b
bs5 js
dgrammatiko Jan 9, 2021
5632969
Init
dgrammatiko Jan 10, 2021
a895329
Clean up the mess
dgrammatiko Jan 12, 2021
28d5520
remove test code
dgrammatiko Jan 12, 2021
345d6f2
Add Toast support
dgrammatiko Jan 12, 2021
a8b1cee
version correction
dgrammatiko Jan 12, 2021
7c98ab0
tooltips + popups
dgrammatiko Jan 12, 2021
81d341e
CS
dgrammatiko Jan 12, 2021
66e484b
CS?
dgrammatiko Jan 12, 2021
2013093
CS?.
dgrammatiko Jan 12, 2021
291e601
CS?.#
dgrammatiko Jan 12, 2021
fddb268
Grrr
dgrammatiko Jan 12, 2021
1f94d7b
dropdowns
dgrammatiko Jan 13, 2021
9f8c5dd
v12
dgrammatiko Jan 13, 2021
0729256
missing bs
dgrammatiko Jan 13, 2021
cf914fe
v13
dgrammatiko Jan 13, 2021
273883b
Fix modal fields
dgrammatiko Jan 13, 2021
45084e0
jQuery is not needed here anymore
dgrammatiko Jan 13, 2021
4aaec52
Modal fixes
dgrammatiko Jan 13, 2021
110af96
Modal further fixes
dgrammatiko Jan 13, 2021
c6d9d5e
Fix stats admin module js
wilsonge Jan 14, 2021
0ed7150
Move from bs4 to bs5 and half-attempt to migrate the SCSS
wilsonge Jan 11, 2021
6090523
Fix CSS Vars prefix
wilsonge Jan 11, 2021
9580d5b
Changes to make styling match
wilsonge Jan 12, 2021
fe2c31c
Breakpoints and utils restored
wilsonge Jan 12, 2021
8588a4c
Alias custom-select class
wilsonge Jan 12, 2021
372544e
More BS4 compat + remove input-group-append
wilsonge Jan 12, 2021
7341182
Fix colour
wilsonge Jan 12, 2021
d849fa7
Revert some of the code to use official bootstrap js
wilsonge Jan 13, 2021
dd3cc49
Add back white scss variable
wilsonge Jan 13, 2021
d38246c
All remaining breakpoints and add back white css var
wilsonge Jan 13, 2021
4958e11
Remove input-append and input-prepend classes
wilsonge Jan 13, 2021
c172df6
Remove commented code
wilsonge Jan 14, 2021
d66cb8d
Fix close button of modals
wilsonge Jan 14, 2021
b8de626
Article padding cleanup
wilsonge Jan 14, 2021
9b286b9
Remove btn-block class
wilsonge Jan 15, 2021
62f214b
Add back some spacing to card columns
wilsonge Jan 15, 2021
cf1a370
Replace float-left and float-right
wilsonge Jan 15, 2021
ef6df7f
Revert back layouts to original locations
wilsonge Jan 15, 2021
8041ca9
Fixed some styles on the last step of the installation process. (#51)
todordev Jan 15, 2021
97ec1c8
Spaces to tabs
wilsonge Jan 15, 2021
3edb5a1
SCSS Lint
wilsonge Jan 16, 2021
73058df
Fix JS Codestyle
wilsonge Jan 16, 2021
ade885d
Improved fix to toolbar dropdowns
wilsonge Jan 16, 2021
951c061
Comments for the changes
wilsonge Jan 16, 2021
49c1a33
Spaces to tabs
wilsonge Jan 16, 2021
fdc8178
Various fixes
wilsonge Jan 16, 2021
651859a
Try and fix tests in a dirty way
wilsonge Jan 16, 2021
491f9b0
Move sr-only to visually-hidden
wilsonge Jan 16, 2021
ee417a7
Spaces to tabs
wilsonge Jan 16, 2021
9b62cf6
Rename files back to original versions
wilsonge Jan 16, 2021
1ae3d75
SCSS Lint
wilsonge Jan 16, 2021
976b6ee
Missing helpers in atum
wilsonge Jan 16, 2021
ca23671
Remove test property
wilsonge Jan 16, 2021
4c3f66d
Update administrator/templates/atum/scss/vendor/_bootstrap.scss
wilsonge Jan 16, 2021
7acaeb8
Update administrator/components/com_menus/tmpl/menus/default.php
wilsonge Jan 16, 2021
6ef8eed
Update administrator/templates/atum/html/layouts/chromes/body.php
wilsonge Jan 16, 2021
4f3c446
Update administrator/templates/atum/html/layouts/chromes/well.php
wilsonge Jan 16, 2021
a5d32a7
Fix modal not showing
wilsonge Jan 17, 2021
26535d6
Update administrator/components/com_postinstall/tmpl/messages/default…
wilsonge Jan 17, 2021
8494749
ml renamed to me (right -> end)
dgrammatiko Jan 17, 2021
2089121
Margin classes
wilsonge Jan 17, 2021
23d869c
Backport sr-only class
wilsonge Jan 17, 2021
c72e06a
Remove comment
wilsonge Jan 18, 2021
62b7587
Badge backgrounds (#52)
ciar4n Jan 18, 2021
0787226
cs
HLeithner Jan 18, 2021
abbf1b2
Update modules/mod_stats/tmpl/default.php
wilsonge Jan 18, 2021
141ab68
Duplicate class names for puublished field
wilsonge Jan 18, 2021
063b2b4
Text-left and text-right
wilsonge Jan 18, 2021
34ed80c
Fix error in system view
wilsonge Jan 18, 2021
b31e770
Fix range form field class
wilsonge Jan 18, 2021
75bb454
Fix JS error
wilsonge Jan 18, 2021
f579769
Fix close button on modal
wilsonge Jan 18, 2021
fbf49b3
Dropdown menu and btn close
wilsonge Jan 19, 2021
d678c03
Use .form-select (#55)
ciar4n Jan 19, 2021
7a5691c
Adding delay in toggleSendMail test (#56)
Hackwar Jan 19, 2021
a20d183
Use alternative method to click radio button switcher (#57)
Hackwar Jan 20, 2021
5135c37
Update libraries/src/HTML/Helpers/Grid.php
wilsonge Jan 20, 2021
92f6bae
Update libraries/src/HTML/Helpers/Grid.php
wilsonge Jan 20, 2021
ed52c04
Fix input
wilsonge Jan 20, 2021
476c296
Fix button group styling
wilsonge Jan 20, 2021
71a446b
Fix language overrides missing results (#58)
dgrammatiko Jan 20, 2021
4a500c5
J4 table styling
ciar4n Jan 20, 2021
819bdae
Update login.php
ciar4n Jan 20, 2021
d0e4732
Update _variables.scss
ciar4n Jan 20, 2021
c1776a3
Update joomla-image-select.css
ciar4n Jan 20, 2021
c431055
Fix input
Jan 21, 2021
75b33c2
Fix input
Jan 21, 2021
d85ab11
Fix accordions
wilsonge Jan 22, 2021
24f58c6
Merge branch '4.0-dev' into bs5
wilsonge Jan 22, 2021
cbe7060
Fix margins on media manager file tree
wilsonge Jan 22, 2021
9d32fe8
Fix some table styling
wilsonge Jan 22, 2021
8b9413e
Fix border issue on hovered vertical tabs
wilsonge Jan 22, 2021
b52d728
Whoops
wilsonge Jan 22, 2021
acf851c
Fix modal padding on header
wilsonge Jan 22, 2021
40ab1fd
More com_media tweaks
wilsonge Jan 22, 2021
e0a7efb
Fix data attributes for launching modals
wilsonge Jan 22, 2021
8bcc1c3
Missing dependency on bootstrap framework
wilsonge Jan 22, 2021
3d4250c
Fix pagination dropdown to be a slect
wilsonge Jan 22, 2021
5e56a0f
Play with form-inline to backport - but also remove some core instances
wilsonge Jan 22, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ protected function getInput()
);

return '<div class="alert alert-info">'
. '<span class="icon-info-circle" aria-hidden="true"></span><span class="sr-only">'
. '<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden">'
. Text::_('INFO')
. '</span>'
. Text::sprintf('PLG_SYSTEM_ACTIONLOGS_JOOMLA_ACTIONLOG_DISABLED_REDIRECT', $link)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
<?php echo LayoutHelper::render('joomla.searchtools.default', array('view' => $this)); ?>
<?php if (empty($this->items)) : ?>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="sr-only"><?php echo Text::_('INFO'); ?></span>
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>
<?php else : ?>
<table class="table" id="logsList">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_ACTIONLOGS_TABLE_CAPTION'); ?>,
<span id="orderedBy"><?php echo Text::_('JGLOBAL_SORTED_BY'); ?> </span>,
<span id="filteredBy"><?php echo Text::_('JGLOBAL_FILTERED_BY'); ?></span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ public function writable($writable)
{
if ($writable)
{
return '<span class="badge badge-success">' . Text::_('COM_ADMIN_WRITABLE') . '</span>';
return '<span class="badge bg-success">' . Text::_('COM_ADMIN_WRITABLE') . '</span>';
}

return '<span class="badge badge-danger">' . Text::_('COM_ADMIN_UNWRITABLE') . '</span>';
return '<span class="badge bg-danger">' . Text::_('COM_ADMIN_UNWRITABLE') . '</span>';
}

/**
Expand Down
2 changes: 1 addition & 1 deletion administrator/components/com_admin/tmpl/help/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<form action="<?php echo Route::_('index.php?option=com_admin&amp;view=help'); ?>" method="post" name="adminForm" id="adminForm">
<div class="row mt-sm-3">
<div id="sidebar" class="col-md-3">
<button class="btn btn-sm btn-secondary my-2 options-menu d-md-none" type="button" data-toggle="collapse" data-target=".sidebar-nav" aria-controls="sidebar-nav" aria-expanded="false">
<button class="btn btn-sm btn-secondary my-2 options-menu d-md-none" type="button" data-bs-toggle="collapse" data-bs-target=".sidebar-nav" aria-controls="sidebar-nav" aria-expanded="false">
<span class="icon-align-justify" aria-hidden="true"></span>
<?php echo Text::_('JTOGGLE_SIDEBAR_MENU'); ?>
</button>
Expand Down
6 changes: 3 additions & 3 deletions administrator/components/com_admin/tmpl/profile/edit.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class="form-validate"
</label>
</div>
<div class="controls">
<?php echo HTMLHelper::_('select.genericlist', UsersHelper::getTwoFactorMethods(), 'jform[twofactor][method]', ['onchange' => 'Joomla.twoFactorMethodChange();', 'class' => 'custom-select'], 'value', 'text', $this->otpConfig->method, 'jform_twofactor_method', false); ?>
<?php echo HTMLHelper::_('select.genericlist', UsersHelper::getTwoFactorMethods(), 'jform[twofactor][method]', ['onchange' => 'Joomla.twoFactorMethodChange();', 'class' => 'form-select'], 'value', 'text', $this->otpConfig->method, 'jform_twofactor_method', false); ?>
</div>
</div>
<div id="com_users_twofactor_forms_container">
Expand All @@ -64,12 +64,12 @@ class="form-validate"
<?php echo Text::_('COM_ADMIN_PROFILE_OTEPS'); ?>
</legend>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="sr-only"><?php echo Text::_('INFO'); ?></span>
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('COM_ADMIN_PROFILE_OTEPS_DESC'); ?>
</div>
<?php if (empty($this->otpConfig->otep)) : ?>
<div class="alert alert-warning">
<span class="icon-exclamation-circle" aria-hidden="true"></span><span class="sr-only"><?php echo Text::_('WARNING'); ?></span>
<span class="icon-exclamation-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('WARNING'); ?></span>
<?php echo Text::_('COM_ADMIN_PROFILE_OTEPS_WAIT_DESC'); ?>
</div>
<?php else : ?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
?>
<div class="sysinfo">
<table class="table">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_ADMIN_CONFIGURATION_FILE'); ?>
</caption>
<thead>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
?>
<div class="sysinfo">
<table class="table">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_ADMIN_DIRECTORY_PERMISSIONS'); ?>
</caption>
<thead>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
?>
<div class="sysinfo">
<table class="table">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_ADMIN_PHP_SETTINGS'); ?>
</caption>
<thead>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
?>
<div class="sysinfo">
<table class="table">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_ADMIN_SYSTEM_INFORMATION'); ?>
</caption>
<thead>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
<?php $itemTypeField = $data['view']->filterForm->getField('itemtype'); ?>
<div class="js-stools-container-selector">
<div class="js-stools-field-selector js-stools-itemtype">
<div class="sr-only"><?php echo $itemTypeField->label; ?></div>
<div class="visually-hidden"><?php echo $itemTypeField->label; ?></div>
<?php echo $itemTypeField->input; ?>
</div>
</div>
Expand All @@ -100,7 +100,7 @@
<?php $languageField = $data['view']->filterForm->getField('language'); ?>
<div class="js-stools-container-selector">
<div class="js-stools-field-selector js-stools-language">
<div class="sr-only"><?php echo $languageField->label; ?></div>
<div class="visually-hidden"><?php echo $languageField->label; ?></div>
<?php echo $languageField->input; ?>
</div>
</div>
Expand All @@ -110,7 +110,7 @@
<?php echo LayoutHelper::render('joomla.searchtools.default.selector', $data); ?>
</div>
<?php endif; ?>
<div class="js-stools-container-bar ml-auto">
<div class="js-stools-container-bar ms-auto">
<div class="btn-toolbar">
<?php echo $this->sublayout('bar', $data); ?>
<?php echo $this->sublayout('list', $data); ?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ protected function getInput()
. ' type="button"'
. ' id="select-change"'
. ' class="btn btn-secondary' . ($value ? '' : ' hidden') . '"'
. ' data-toggle="modal"'
. ' data-bs-toggle="modal"'
. ' data-select="' . Text::_('COM_ASSOCIATIONS_SELECT_TARGET') . '"'
. ' data-change="' . Text::_('COM_ASSOCIATIONS_CHANGE_TARGET') . '"'
. ' data-target="#associationSelect' . $this->id . 'Modal">'
. ' data-bs-target="#associationSelect' . $this->id . 'Modal">'
. '<span class="icon-file" aria-hidden="true"></span> '
. '<span id="select-change-text"></span>'
. '</button>';
Expand Down Expand Up @@ -97,7 +97,7 @@ protected function getInput()
'width' => '800px',
'bodyHeight' => 70,
'modalWidth' => 80,
'footer' => '<button type="button" class="btn btn-secondary" data-dismiss="modal">'
'footer' => '<button type="button" class="btn btn-secondary" data-bs-dismiss="modal">'
. Text::_("JLIB_HTML_BEHAVIOR_CLOSE") . '</button>',
)
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ public static function getAssociationHtmlList($extensionName, $typeName, $itemId
$additional = '<strong>' . Text::sprintf('COM_MENUS_MENU_SPRINTF', $menutypeTitle) . '</strong><br>';
}

$labelClass = 'badge-secondary';
$labelClass = 'bg-secondary';
$target = $langCode . ':' . $items[$langCode]['id'] . ':edit';
$allow = $canEditReference
&& self::allowEdit($extensionName, $typeName, $items[$langCode]['id'])
Expand All @@ -313,7 +313,7 @@ public static function getAssociationHtmlList($extensionName, $typeName, $itemId

$title = Text::_('COM_ASSOCIATIONS_NO_ASSOCIATION');
$additional = $addLink ? Text::_('COM_ASSOCIATIONS_ADD_NEW_ASSOCIATION') : '';
$labelClass = 'badge-warning';
$labelClass = 'bg-warning text-dark';
$target = $langCode . ':0:add';
$allow = $canCreate;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<h3 class="target-text"><?php echo Text::_('COM_ASSOCIATIONS_ASSOCIATED_ITEM'); ?></h3>
</div>
<div class="langtarget">
<div class="sr-only">
<div class="visually-hidden">
<?php echo $this->form->getLabel('itemlanguage'); ?>
</div>
<?php echo $this->form->getInput('itemlanguage'); ?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,17 @@
<?php echo LayoutHelper::render('joomla.searchtools.default', array('view' => $this)); ?>
<?php if ($this->state->get('itemtype') == '' || $this->state->get('language') == '') : ?>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="sr-only"><?php echo Text::_('INFO'); ?></span>
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('COM_ASSOCIATIONS_NOTICE_NO_SELECTORS'); ?>
</div>
<?php elseif (empty($this->items)) : ?>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="sr-only"><?php echo Text::_('INFO'); ?></span>
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>
<?php else : ?>
<table class="table" id="associationsList">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_ASSOCIATIONS_TABLE_CAPTION'); ?>,
<span id="orderedBy"><?php echo Text::_('JGLOBAL_SORTED_BY'); ?> </span>,
<span id="filteredBy"><?php echo Text::_('JGLOBAL_FILTERED_BY'); ?></span>
Expand Down Expand Up @@ -106,7 +106,7 @@
</td>
<?php endif; ?>
<th scope="row" class="has-context">
<div class="float-left break-word">
<div class="float-start break-word">
<?php if (isset($item->level)) : ?>
<?php echo LayoutHelper::render('joomla.html.treeprefix', array('level' => $item->level)); ?>
<?php endif; ?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@
<?php echo LayoutHelper::render('joomla.searchtools.default', array('view' => $this)); ?>
<?php if (empty($this->items)) : ?>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="sr-only"><?php echo Text::_('INFO'); ?></span>
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>
<?php else : ?>
<table class="table" id="associationsList">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_ASSOCIATIONS_TABLE_CAPTION'); ?>,
<span id="orderedBy"><?php echo Text::_('JGLOBAL_SORTED_BY'); ?> </span>,
<span id="filteredBy"><?php echo Text::_('JGLOBAL_FILTERED_BY'); ?></span>
Expand Down
2 changes: 1 addition & 1 deletion administrator/components/com_banners/forms/banner.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
name="state"
type="list"
label="JSTATUS"
class="custom-select-color-state"
class="form-select-color-state"
size="1"
default="1"
validate="options"
Expand Down
2 changes: 1 addition & 1 deletion administrator/components/com_banners/forms/client.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
name="state"
type="list"
label="JSTATUS"
class="custom-select-color-state"
class="form-select-color-state"
size="1"
default="1"
validate="options"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ protected function getInput()

return '<div class="input-group"><input class="form-control" type="text" name="' . $this->name . '" id="' . $this->id . '" value="'
. htmlspecialchars($this->value, ENT_COMPAT, 'UTF-8') . '" readonly="readonly">'
. '<span class="input-group-append"><button type="button" class="btn btn-secondary" ' . $onclick . '>'
. '<span class="icon-sync" aria-hidden="true"></span> ' . Text::_('COM_BANNERS_RESET_CLICKS') . '</button></span></div>';
. '<button type="button" class="btn btn-secondary" ' . $onclick . '>'
. '<span class="icon-sync" aria-hidden="true"></span> ' . Text::_('COM_BANNERS_RESET_CLICKS') . '</button></div>';
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ protected function getInput()

return '<div class="input-group"><input class="form-control" type="text" name="' . $this->name . '" id="' . $this->id . '" value="'
. htmlspecialchars($this->value, ENT_COMPAT, 'UTF-8') . '" readonly="readonly">'
. '<span class="input-group-append"><button type="button" class="btn btn-secondary" ' . $onclick . '>'
. '<span class="icon-sync" aria-hidden="true"></span> ' . Text::_('COM_BANNERS_RESET_IMPMADE') . '</button></span></div>';
. '<button type="button" class="btn btn-secondary" ' . $onclick . '>'
. '<span class="icon-sync" aria-hidden="true"></span> ' . Text::_('COM_BANNERS_RESET_IMPMADE') . '</button></div>';
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function clients()
'<label id="batch-client-lbl" for="batch-client-id">',
Text::_('COM_BANNERS_BATCH_CLIENT_LABEL'),
'</label>',
'<select class="custom-select" name="batch[client_id]" id="batch-client-id">',
'<select class="form-select" name="batch[client_id]" id="batch-client-id">',
'<option value="">' . Text::_('COM_BANNERS_BATCH_CLIENT_NOCHANGE') . '</option>',
'<option value="0">' . Text::_('COM_BANNERS_NO_CLIENT') . '</option>',
HTMLHelper::_('select.options', static::clientlist(), 'value', 'text'),
Expand Down
4 changes: 2 additions & 2 deletions administrator/components/com_banners/tmpl/banners/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@
?>
<?php if (empty($this->items)) : ?>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="sr-only"><?php echo Text::_('INFO'); ?></span>
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>
<?php else : ?>
<table class="table" id="articleList">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_BANNERS_BANNERS_TABLE_CAPTION'); ?>,
<span id="orderedBy"><?php echo Text::_('JGLOBAL_SORTED_BY'); ?> </span>,
<span id="filteredBy"><?php echo Text::_('JGLOBAL_FILTERED_BY'); ?></span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/** @var \Joomla\Component\Banners\Administrator\View\Banners\HtmlView $this */

?>
<button type="button" class="btn btn-secondary" onclick="document.getElementById('batch-category-id').value='';document.getElementById('batch-client-id').value='';document.getElementById('batch-language-id').value=''" data-dismiss="modal">
<button type="button" class="btn btn-secondary" onclick="document.getElementById('batch-category-id').value='';document.getElementById('batch-client-id').value='';document.getElementById('batch-language-id').value=''" data-bs-dismiss="modal">
<?php echo Text::_('JCANCEL'); ?>
</button>
<button type="submit" class="btn btn-success" onclick="Joomla.submitbutton('banner.batch');return false;">
Expand Down
12 changes: 6 additions & 6 deletions administrator/components/com_banners/tmpl/clients/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@
?>
<?php if (empty($this->items)) : ?>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="sr-only"><?php echo Text::_('INFO'); ?></span>
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>
<?php else : ?>
<table class="table">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_BANNERS_CLIENTS_TABLE_CAPTION'); ?>,
<span id="orderedBy"><?php echo Text::_('JGLOBAL_SORTED_BY'); ?> </span>,
<span id="filteredBy"><?php echo Text::_('JGLOBAL_FILTERED_BY'); ?></span>
Expand All @@ -70,19 +70,19 @@
</th>
<th scope="col" class="w-3 text-center d-none d-md-table-cell">
<span class="icon-check" aria-hidden="true" title="<?php echo Text::_('COM_BANNERS_COUNT_PUBLISHED_ITEMS'); ?>"></span>
<span class="sr-only"><?php echo Text::_('COM_BANNERS_COUNT_PUBLISHED_ITEMS'); ?></span>
<span class="visually-hidden"><?php echo Text::_('COM_BANNERS_COUNT_PUBLISHED_ITEMS'); ?></span>
</th>
<th scope="col" class="w-3 text-center d-none d-md-table-cell">
<span class="icon-times" aria-hidden="true" title="<?php echo Text::_('COM_BANNERS_COUNT_UNPUBLISHED_ITEMS'); ?>"></span>
<span class="sr-only"><?php echo Text::_('COM_BANNERS_COUNT_UNPUBLISHED_ITEMS'); ?></span>
<span class="visually-hidden"><?php echo Text::_('COM_BANNERS_COUNT_UNPUBLISHED_ITEMS'); ?></span>
</th>
<th scope="col" class="w-3 text-center d-none d-md-table-cell">
<span class="icon-folder icon-fw" aria-hidden="true" title="<?php echo Text::_('COM_BANNERS_COUNT_ARCHIVED_ITEMS'); ?>"></span>
<span class="sr-only"><?php echo Text::_('COM_BANNERS_COUNT_ARCHIVED_ITEMS'); ?></span>
<span class="visually-hidden"><?php echo Text::_('COM_BANNERS_COUNT_ARCHIVED_ITEMS'); ?></span>
</th>
<th scope="col" class="w-3 text-center d-none d-md-table-cell">
<span class="icon-trash" aria-hidden="true" title="<?php echo Text::_('COM_BANNERS_COUNT_TRASHED_ITEMS'); ?>"></span>
<span class="sr-only"><?php echo Text::_('COM_BANNERS_COUNT_TRASHED_ITEMS'); ?></span>
<span class="visually-hidden"><?php echo Text::_('COM_BANNERS_COUNT_TRASHED_ITEMS'); ?></span>
</th>
<th scope="col" class="w-10 d-none d-md-table-cell">
<?php echo HTMLHelper::_('searchtools.sort', 'COM_BANNERS_HEADING_PURCHASETYPE', 'a.purchase_type', $listDirn, $listOrder); ?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class="form-horizontal form-validate"
<?php echo $this->form->renderField($field->fieldname); ?>
<?php endforeach; ?>

<button class="sr-only"
<button class="visually-hidden"
id="exportBtn"
type="button"
onclick="this.form.submit();window.top.setTimeout('window.parent.Joomla.Modal.getCurrent().close()', 700);">
Expand Down
4 changes: 2 additions & 2 deletions administrator/components/com_banners/tmpl/tracks/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@
<?php echo LayoutHelper::render('joomla.searchtools.default', ['view' => $this]); ?>
<?php if (empty($this->items)) : ?>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="sr-only"><?php echo Text::_('INFO'); ?></span>
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>
<?php else : ?>
<table class="table">
<caption class="sr-only">
<caption class="visually-hidden">
<?php echo Text::_('COM_BANNERS_TRACKS_TABLE_CAPTION'); ?>,
<span id="orderedBy"><?php echo Text::_('JGLOBAL_SORTED_BY'); ?> </span>,
<span id="filteredBy"><?php echo Text::_('JGLOBAL_FILTERED_BY'); ?></span>
Expand Down
Loading