Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .eslintrc max length #34973

Merged
merged 5 commits into from
Jul 30, 2021
Merged

Update .eslintrc max length #34973

merged 5 commits into from
Jul 30, 2021

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Jul 29, 2021

Pull Request for Issue # .

Summary of Changes

  • Adjusts the length of the line to 150 chars (same as PHP)

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@brianteeman
Copy link
Contributor

seems reasonable

@dgrammatiko
Copy link
Contributor Author

seems reasonable

@Fedik was also asking for an increased line length. I'm not sure though if the php length is really 160

@brianteeman
Copy link
Contributor

My comment on it being reasonable was based on the comment "same as php"

@dgrammatiko
Copy link
Contributor Author

@richard67
Copy link
Member

I have tested this item ✅ successfully on 5aa45bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34973.

@HLeithner
Copy link
Member

I thought we follow the airbnb style guide why do we need exceptions?

@dgrammatiko
Copy link
Contributor Author

I thought we follow the airbnb style guide why do we need exceptions?

We already have some exceptions and also the idea is to adapt the tools to our needs. Right now the tool is dictating something that's not in line with the rest of the project (php files are 150 chr long). In short tools are not rules

@Fedik
Copy link
Member

Fedik commented Jul 29, 2021

I have tested this item ✅ successfully on 5aa45bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34973.

@Fedik Fedik added the RTC This Pull Request is Ready To Commit label Jul 29, 2021
@richard67 richard67 removed the RTC This Pull Request is Ready To Commit label Jul 29, 2021
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34973.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 29, 2021
@wilsonge wilsonge merged commit bbb1e93 into joomla:4.0-dev Jul 30, 2021
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 30, 2021
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jul 30, 2021
@dgrammatiko dgrammatiko deleted the patch-4 branch July 30, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants