-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .eslintrc max length #34973
Update .eslintrc max length #34973
Conversation
seems reasonable |
@Fedik was also asking for an increased line length. I'm not sure though if the php length is really 160 |
My comment on it being reasonable was based on the comment "same as php" |
I have tested this item ✅ successfully on 5aa45bd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34973. |
I thought we follow the airbnb style guide why do we need exceptions? |
We already have some exceptions and also the idea is to adapt the tools to our needs. Right now the tool is dictating something that's not in line with the rest of the project (php files are 150 chr long). In short tools are not rules |
I have tested this item ✅ successfully on 5aa45bd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34973. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34973. |
Thanks! |
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required