Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] add target and rel values in com_installer.ini #37475

Merged
merged 2 commits into from
Apr 23, 2022

Conversation

tecpromotion
Copy link
Contributor

Summary of Changes

add target=_blank and rel=noopener noreferrer for external links

Testing Instructions

Clicking on the links opens the target in a new window and "noopener noreferrer" is passed as rel values.

Actual result BEFORE applying this Pull Request

A link does not open in a new window.
Both links have no rel values.

Expected result AFTER applying this Pull Request

target=\"_blank\" rel=\"noopener noreferrer\" for external links

Documentation Changes Required

.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Apr 4, 2022
@brianteeman
Copy link
Contributor

originally we did not add rel= to these links as it was felt that we could trut our own web sites

@tecpromotion
Copy link
Contributor Author

originally we did not add rel= to these links as it was felt that we could trut our own web sites

There are currently 11 links to https://docs.joomla.org in use like this.
I would be happy if we could standardise this.

@simbus82
Copy link
Contributor

simbus82 commented Apr 4, 2022

originally we did not add rel= to these links as it was felt that we could trut our own web sites

Anyway It's a best practice to use Noopener for linking external sites. The "noopener" attribute ensures that the page opened in a new tab cannot take control of the original page (Reverse Tabnabbing attack). It is useful for both safety and performance and you never know what can happen...
I have some doubts about the use of the noreferrer, in fact the only effect is that the analytics of the joomla sites would see direct traffic instead of referral traffic.
Using it maybe allows us to say that Joomla.org does not read any data from the Joomla installed (without the noreferrer if I click on those links, the Joomla.org analytics sees my domain inside the referrer).

@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@kiki-G
Copy link

kiki-G commented Apr 22, 2022

I have tested this item ✅ successfully on 302fe4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37475.

@joomla joomla deleted a comment from kiki-G Apr 22, 2022
@RickR2H
Copy link
Member

RickR2H commented Apr 22, 2022

I have tested this item ✅ successfully on 302fe4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37475.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PBF Pizza, Bugs and Fun PR-4.1-dev labels Apr 22, 2022
@RickR2H
Copy link
Member

RickR2H commented Apr 22, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37475.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 22, 2022
@RickR2H RickR2H added Language Change This is for Translators PBF Pizza, Bugs and Fun PR-4.1-dev labels Apr 22, 2022
@laoneo laoneo merged commit a06f8c0 into joomla:4.1-dev Apr 23, 2022
@laoneo
Copy link
Member

laoneo commented Apr 23, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 23, 2022
@laoneo laoneo added this to the Joomla 4.1.3 milestone Apr 23, 2022
@richard67 richard67 removed the PBF Pizza, Bugs and Fun label Apr 30, 2022
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 2, 2022
joomla/joomla-cms#37115 +
joomla/joomla-cms#37286 + (отдельно в 857dcac)
joomla/joomla-cms#37464 +
joomla/joomla-cms#36250 +
joomla/joomla-cms#37527 +
joomla/joomla-cms#37535 - (только для en-GB)
joomla/joomla-cms#37559 +
joomla/joomla-cms#37594 - (только для en-GB)
joomla/joomla-cms#37588 +
joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями)
joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено)
joomla/joomla-cms#37564 +
joomla/joomla-cms#37641 - (только для en-GB)
joomla/joomla-cms#37657 +
joomla/joomla-cms#37683 +
joomla/joomla-cms#37666 +
joomla/joomla-cms#37704 +
joomla/joomla-cms#37689 +
joomla/joomla-cms#37519 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants