Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Inject the cache controller factory #37517

Merged
merged 14 commits into from
Jun 12, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 8, 2022

Summary of Changes

Adds a new interface and trait to inject a CacheControllerFactoryInterface. Where possible this is used now in core.

Testing Instructions

Open the back end.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

@brianteeman
Copy link
Contributor

Impossible to test from the instructions provided

@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@SumCompanyInc
Copy link

the backend works after applying the patch?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517.

@SumCompanyInc
Copy link

I have tested this item ✅ successfully on 7205827

if it's just opening the backend, it opened fine for me after applying patch


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on bb90f76

Apply patch, access to random pages from both frontend and backend, with both cache enabled/disabled, nothing is broken.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517.

@joomdonation
Copy link
Contributor

@SumCompanyInc Could you please re-test this PR ? Thanks.

@laoneo
Copy link
Member Author

laoneo commented Jun 9, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 9, 2022
@laoneo
Copy link
Member Author

laoneo commented Jun 9, 2022

No need for a second test as I added only a unit test and made a function protected.

@roland-d roland-d merged commit b102a26 into joomla:4.2-dev Jun 12, 2022
@roland-d roland-d deleted the j4/cache/inject branch June 12, 2022 07:27
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 12, 2022
@roland-d
Copy link
Contributor

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PBF Pizza, Bugs and Fun Unit/System Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants