-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Inject the cache controller factory #37517
Conversation
Impossible to test from the instructions provided |
the backend works after applying the patch? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517. |
I have tested this item ✅ successfully on 7205827 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517. |
I have tested this item ✅ successfully on bb90f76 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517. |
@SumCompanyInc Could you please re-test this PR ? Thanks. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517. |
No need for a second test as I added only a unit test and made a function protected. |
Co-authored-by: Quy <quy@fluxbb.org>
Thanks everybody |
Summary of Changes
Adds a new interface and trait to inject a
CacheControllerFactoryInterface
. Where possible this is used now in core.Testing Instructions
Open the back end.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.