Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12 reached EOL #37757

Merged
merged 5 commits into from
May 18, 2022
Merged

Node 12 reached EOL #37757

merged 5 commits into from
May 18, 2022

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented May 7, 2022

Pull Request for Issue # .

Summary of Changes

Use the current Node/Npm


schedule

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Yes, all docs that have hardcoded the min version for Node/NPM need an update

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels May 7, 2022
@zero-24
Copy link
Contributor

zero-24 commented May 7, 2022

FYI i have added a signature which should let drone accept the changes to the drone file ;)

@dgrammatiko
Copy link
Contributor Author

Thanks Tobias 👍

@bembelimen bembelimen merged commit 0fd479e into joomla:4.1-dev May 18, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.4 milestone May 18, 2022
@dgrammatiko dgrammatiko deleted the patch-2 branch May 18, 2022 17:43
@HLeithner
Copy link
Member

Seems some of our ci doesn't work with the new version... for example nightlies and PR packager/download

@dgrammatiko
Copy link
Contributor Author

@HLeithner where is the code for those?

@HLeithner
Copy link
Member

Hannes and me fixing it now, its at github.com/joomla-projects/docker-images packager branch

@dgrammatiko
Copy link
Contributor Author

@HLeithner let me know if I can somehow help

@HLeithner
Copy link
Member

What's the best way to install/update node on debian?

@dgrammatiko
Copy link
Contributor Author

If you have snap: sudo snap install node --classic --channel=18
if not apt-get update && apt-get install snapd then the above command

@HLeithner
Copy link
Member

I decided todo the offical way using https://github.com/nodesource/distributions/blob/master/README.md

@dgrammatiko
Copy link
Contributor Author

@HLeithner just make sure you go with 18. The 16 on the main repo is ok as the code is expected to be used from devs so switching directly to 18 (skipping 16 that has a 6 or so more months till EOL) would forced more people to update their node. But internal tooling is ok to use 18 (one less update for October)

@HLeithner
Copy link
Member

ok, I also wanted to ask this^^

@dgrammatiko
Copy link
Contributor Author

@HLeithner fyi: #37830

@Hackwar
Copy link
Member

Hackwar commented May 22, 2022

This is still not really the way I like it, but anyway. My big problem right now is, that the node:16-alpine docker image has npm 8.5.5 installed, while our package.json requires npm 8.6.0. That means we get an error at the beginning of each npm build. Is there a reason for using npm 8.6.0 as requirement instead of 8.5.5? I don't care which way we go, but I want that error to be gone...

@dgrammatiko
Copy link
Contributor Author

@Hackwar #37830 sets npm min to 8.5.5

@Hackwar
Copy link
Member

Hackwar commented May 22, 2022

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester Unit/System Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants