-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 12 reached EOL #37757
Node 12 reached EOL #37757
Conversation
FYI i have added a signature which should let drone accept the changes to the drone file ;) |
Thanks Tobias 👍 |
Thx |
Seems some of our ci doesn't work with the new version... for example nightlies and PR packager/download |
@HLeithner where is the code for those? |
Hannes and me fixing it now, its at github.com/joomla-projects/docker-images packager branch |
@HLeithner let me know if I can somehow help |
What's the best way to install/update node on debian? |
If you have snap: |
I decided todo the offical way using https://github.com/nodesource/distributions/blob/master/README.md |
@HLeithner just make sure you go with 18. The 16 on the main repo is ok as the code is expected to be used from devs so switching directly to 18 (skipping 16 that has a 6 or so more months till EOL) would forced more people to update their node. But internal tooling is ok to use 18 (one less update for October) |
ok, I also wanted to ask this^^ |
@HLeithner fyi: #37830 |
This is still not really the way I like it, but anyway. My big problem right now is, that the node:16-alpine docker image has npm 8.5.5 installed, while our package.json requires npm 8.6.0. That means we get an error at the beginning of each npm build. Is there a reason for using npm 8.6.0 as requirement instead of 8.5.5? I don't care which way we go, but I want that error to be gone... |
thx |
Pull Request for Issue # .
Summary of Changes
Use the current Node/Npm
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
Yes, all docs that have hardcoded the min version for Node/NPM need an update