-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Convert joomla action log plugin to services #37788
[4.2] Convert joomla action log plugin to services #37788
Conversation
@laoneo It has some CS errors: https://ci.joomla.org/joomla/joomla-cms/54000/1/6 |
I have tested this item ✅ successfully on 02b0b6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788. |
…/joomla-cms into j4/plugins/actionlog/joomla
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Sorry for the very long delay, I am refactoring Joomla's Two Factor Authentication. Overall it works fine for me, I juts have one question. Since we are going into the trouble of converting the plugin, shouldn't we also convert it to use SubscriberInterface? At some point in the future #36578 will be merged in the core. Having the plugin use SubscriberInterface would make quick work of converting it once the concrete events classes are written (phase 2 of the work on that PR). It could even serve as a proof of the concept in the core. Totally optional, just thinking out loud. |
I guess when #36578 got merged, then we can use the SubscriberInterface. Till then we have to use the legacy subscribing way. But SubscriberInterface is definitely the way to go. |
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Suggestion, lower case: (I don't know if this is related to this issue ?) |
To which issue? |
I mean, change here too. |
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
…/joomla-cms into j4/plugins/actionlog/joomla
I have tested this item ✅ successfully on a878b87 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788. |
@sandewt changed it. Can you give this plugin also a test? |
I'm going to do it, but see my comment what I came across during testing. |
I have tested this item ✅ successfully on a878b87 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788. |
I have tested this item ✅ successfully on a878b87 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37788. |
Thanks everybody |
Summary of Changes
Converts the joomla action log plugin to services.
The action log component changes from #37592 are included here too, otherwise we will have a conflict after merge.
@nikosdion you may want to have a look here too.
Testing Instructions
Actual result BEFORE applying this Pull Request
Action log entry is written for an article create action.
Expected result AFTER applying this Pull Request
Action log entry is written for an article create action.