[4.1] Initialize the contact text attribute as string #37836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 275ad19 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37836. |
1 similar comment
|
I have tested this item ✅ successfully on 275ad19 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37836. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37836. |
|
Thx |
richard67
pushed a commit
to richard67/joomla-cms
that referenced
this pull request
May 21, 2022
richard67
pushed a commit
to richard67/joomla-cms
that referenced
this pull request
May 21, 2022
richard67
pushed a commit
to richard67/joomla-cms
that referenced
this pull request
May 21, 2022
richard67
pushed a commit
to richard67/joomla-cms
that referenced
this pull request
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When triggering the
onContentPrepareevent in the contact details page, the text attribute is expected to be a string. On PHP 8.1 a couple of deprecated messages are displayed as it is currently null.Testing Instructions
Actual result BEFORE applying this Pull Request
The following deprecated message is displayed:
Deprecated: strpos(): Passing null to parameter 1 ($haystack) of type string is deprecated in /plugins/content/loadmodule/loadmodule.php on line 49
Expected result AFTER applying this Pull Request
No warning.