Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Template Details and Files (tabs) #37855

Merged
merged 11 commits into from
Jun 6, 2022
Merged

[4.2] Template Details and Files (tabs) #37855

merged 11 commits into from
Jun 6, 2022

Conversation

Kostelano
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

The PR moves the override update tab next to the create override tab, which seems much more logical to me. Accordingly - the description of the template - to the end.

Also reduced the indentation to the one used in other tabs (mt-2).

Screenshot_1

Testing Instructions

System - Site Templates, Cassiopeia Details and Files, check the tabs.

@Quy
Copy link
Contributor

Quy commented May 24, 2022

I have tested this item ✅ successfully on b13f523


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37855.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on b30960f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37855.

@Quy
Copy link
Contributor

Quy commented May 30, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37855.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 30, 2022
@bembelimen
Copy link
Contributor

Fine for me, but for 4.2 then

@bembelimen bembelimen changed the base branch from 4.1-dev to 4.2-dev June 5, 2022 22:44
@Kostelano Kostelano changed the title [4.1] Template Details and Files (tabs) [4.2] Template Details and Files (tabs) Jun 6, 2022
@roland-d roland-d merged commit 4c59ca9 into joomla:4.2-dev Jun 6, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 6, 2022
@roland-d
Copy link
Contributor

roland-d commented Jun 6, 2022

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 6, 2022
@Kostelano Kostelano deleted the 4-1-tamplate-tabs branch June 6, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants