-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[inlinehelp] Add inlineHelp Toggle Button control to modules and plugins #37915
Conversation
@conseilgouz Does it need to apply #37849 , too, for testing this PR? If so, you should mention that in the testing instructions. |
Done |
administrator/components/com_plugins/src/View/Plugin/HtmlView.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Quy <quy@fluxbb.org>
Edit Edit |
Button is now hidden if no description is available in xml
I was not able to reproduce this issue. When I click on button, descriptions are shown/hidden/shown.... |
@conseilgouz Have tested, but not working for plugins and admin modules, because the tag is not at the right place. |
@cyrezdev : done |
Modules admin needed too : https://github.com/joomla/joomla-cms/pull/37915/files#diff-39a20a749da8e579b9b531f02b6648028489795fda3094a78db422b4af5bc44a If you test, you will see that it does not work with admin modules... |
Note: not needed to apply the PR #37849 before tested this one, as it is an improvement that will not change the behavior of your changes here. cc/ @richard67 |
Yes, I missed this one. Done. Thank You. |
I have tested this item ✅ successfully on 473631f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37915. |
I have tested this item ✅ successfully on 473631f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37915. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37915. |
Thx |
Summary of Changes
This PR adds inlineHelp toggle button to modules and plugins options to give users the capability to show/hide parameters descriptions.
This PR improves #35610 and #37849
Instead of always displaying descriptions for modules and plugins, it becomes a user choice. In case of a doubt about a parameter, just click on the button.
Note : it could be improved by adding this to all components. For example, Featured articles menu, Article Class has a 4 lines description, usefull once.
Testing Instructions
Apply PR #37849 before applying this PR.
Actual result BEFORE applying this Pull Request
After #37849 , the default behaviour is "show all descriptions" for modules and plugins parameters if no inlineHelp toggle button is displayed.
Expected result AFTER applying this Pull Request
InlineHelp toogle button is displayed and working for modules/plugins if parameters have descriptions. It is hidden otherwise.
Documentation Changes Required
none