[4.1] added deprecation note for 5.0 signature change #37943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 4dd448b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37943. |
|
I have tested this item ✅ successfully on 4dd448b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37943. |
|
Thanks! |
laoneo
added a commit
to Digital-Peak/joomla-cms
that referenced
this pull request
Jun 1, 2022
This reverts commit e98815c.
HLeithner
pushed a commit
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added a deprecation note to the doc block of the AES class to emphasize the upcoming signature change in 5.x
Actual result BEFORE applying this Pull Request
Note is missing
Expected result AFTER applying this Pull Request
Note is there
Documentation Changes Required