Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Replace Factory::getUser() with $this->getCurrentUser() in components view class #38006

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

With #37498 being merged into 4.2, we can now replace deprecated method Factory::getUser() in components view classes with new method $this->getCurrentUser()

Testing Instructions

  1. Use Joomla 4.2 nightly build
  2. Apply patch
  3. Access to random pages (frontend, backend), make sure nothing is broken.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on e6b89a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38006.

@toivo
Copy link
Contributor

toivo commented Jun 9, 2022

I have tested this item ✅ successfully on e6b89a7

Tested successfully in Joomla 4.2.0-beta1-dev of 9 June


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38006.

@alikon
Copy link
Contributor

alikon commented Jun 9, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38006.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 9, 2022
@laoneo laoneo merged commit bb2e172 into joomla:4.2-dev Jun 9, 2022
@laoneo
Copy link
Member

laoneo commented Jun 9, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 9, 2022
@laoneo laoneo added this to the Joomla 4.2.0 milestone Jun 9, 2022
@joomdonation joomdonation deleted the get_user_in_component_views branch June 9, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants