Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Create traits for the CMSObject error and property handling #39020

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Oct 22, 2022

Summary of Changes

Split the CMSObject into traits so extension developers can already use them and remove their dependency from CMSObject. This pr is based on #38949 as it uses the exception trait.

The traits are deprecated so people will understand their code should be changes accordingly to the deprecate messages. In 5.0 the dependencies to CMSObject are removed from core then and do use the traits to ensure nothing will break in 4.

Testing Instructions

Load any back end view. CMSObject is used in tables and models so loading one of the views will use the CMSObject class.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

@laoneo
Copy link
Member Author

laoneo commented Oct 22, 2022

@wilsonge and @nikosdion feedback is appreciated

@Abernyte-Git
Copy link

I have tested this item ✅ successfully on e993a85


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39020.

@nikosdion
Copy link
Contributor

I am happy with this approach.

@obuisard obuisard added this to the Joomla! 4.3.0 milestone Nov 9, 2022
@obuisard obuisard merged commit e5741dd into joomla:4.3-dev Nov 9, 2022
@obuisard
Copy link
Contributor

obuisard commented Nov 9, 2022

Thank you Allon @laoneo for the PR

@laoneo laoneo deleted the cmsobject/traits branch November 9, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants