-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Revert 38576 #40060
Merged
Merged
[4.3] Revert 38576 #40060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on 2ca9256 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40060. |
1 similar comment
I have tested this item ✅ successfully on 2ca9256 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40060. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40060. |
Thank you Tuan @joomdonation for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR reverts #38576 , solves the release blocker #40052. The original change to the file administrator/components/com_tags/src/Table/TagTable.php is valid, only change to the file libraries/src/Table/ContentType.php is wrong . However, due to the limitation of the current tag routing, we require each tag to have unique alias, so I revert the the whole PR.
Testing Instructions
com_hikashop_starter_v4.7.1_2023-03-09_15-53-14.zip
Actual result BEFORE applying this Pull Request
You got error: Missing field in database: Joomla\CMS\Table\ContentType alias.
Expected result AFTER applying this Pull Request
No error, the extension was installed properly.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed