Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Revert 38576 #40060

Merged
merged 5 commits into from
Mar 11, 2023
Merged

[4.3] Revert 38576 #40060

merged 5 commits into from
Mar 11, 2023

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR reverts #38576 , solves the release blocker #40052. The original change to the file administrator/components/com_tags/src/Table/TagTable.php is valid, only change to the file libraries/src/Table/ContentType.php is wrong . However, due to the limitation of the current tag routing, we require each tag to have unique alias, so I revert the the whole PR.

Testing Instructions

  1. Use Joomla 4.3-dev
  2. Try to install Hikashop extension which can be downloaded below
    com_hikashop_starter_v4.7.1_2023-03-09_15-53-14.zip

Actual result BEFORE applying this Pull Request

You got error: Missing field in database: Joomla\CMS\Table\ContentType   alias.

Expected result AFTER applying this Pull Request

No error, the extension was installed properly.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Mar 10, 2023

I have tested this item ✅ successfully on 2ca9256


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40060.

1 similar comment
@obuisard
Copy link
Contributor

I have tested this item ✅ successfully on 2ca9256


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40060.

@Quy
Copy link
Contributor

Quy commented Mar 11, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40060.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 11, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 11, 2023
@obuisard obuisard merged commit 7cb694d into joomla:4.3-dev Mar 11, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 11, 2023
@obuisard
Copy link
Contributor

Thank you Tuan @joomdonation for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants