Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding direct logout test. #40394

Merged
merged 14 commits into from
Apr 18, 2023
Merged

Adding direct logout test. #40394

merged 14 commits into from
Apr 18, 2023

Conversation

charvimehradu
Copy link
Contributor

Pull Request for Issue #

Adding direct logout test.

@laoneo laoneo added this to the Joomla! 4.4.0 milestone Apr 17, 2023
@laoneo
Copy link
Member

laoneo commented Apr 17, 2023

The tests are failing

@laoneo laoneo self-assigned this Apr 17, 2023
@laoneo laoneo added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 17, 2023
@brianteeman
Copy link
Contributor

The tests are failing

that may well be correct see #37763

@charvimehradu
Copy link
Contributor Author

I'm not sure why these aren't working over here, but they do on my system.

LogoutTestPass

@laoneo
Copy link
Member

laoneo commented Apr 17, 2023

In the artefacts part you will find some information why the test fails https://ci.joomla.org/joomla/joomla-cms/64752/1/37

@laoneo laoneo enabled auto-merge (squash) April 18, 2023 09:22
@laoneo laoneo removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 18, 2023
@laoneo laoneo disabled auto-merge April 18, 2023 09:22
@laoneo laoneo merged commit 0b5bb2b into joomla:4.4-dev Apr 18, 2023
@laoneo
Copy link
Member

laoneo commented Apr 18, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laoneo laoneo laoneo left review comments

Assignees

@laoneo laoneo

Labels
PR-4.4-dev Unit/System Tests
Projects
None yet
Milestone
Joomla! 4.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@charvimehradu @laoneo @brianteeman @joomla-cms-bot