Revert "Use icon exit for close buttons"

[obuisard]

Reverts #40167

Should be something that would be handled in 5.0 rather than in a bug fix release.

[brianteeman]

This makes no sense at all. The change you are reverting here is the icon change NOT the text.

When you create a new article then the text has always been Cancel
When you edit an existing article then the text has always been Close

The only thing the pr did was to change the icon that went with the text.

[Fedik]

@obuisard this will fix the problem:

return $this->standardButton('cancel', $text, $task)->icon('icon-exit');

This will keep old tookbar-cancell ID but use new icon, from the linked PR.

[wilsonge]

@brianteeman not quite. It changed the button name. By default the icon is ‘icon-$name’). Hence the icon changed too. But the name also changed the ID of the button which caused test failures in 4.0. I think @Fedik ‘s solution here is correct

[brianteeman]

yes I see that and I agree with @Fedik

However Allon is saying that the label has changed #40167 (comment)

[wilsonge]

The label hasn’t changed. @chmst tracked that down in the maintainers group earlier. Allon was wrong about that

[brianteeman]

it was only 30 minutes ago that he said that :(

[obuisard]

The fix from Fedir @Fedik is a good solution but looking at it more closely, brought up to the surface some inconsistencies we have in the toolbars (for instance, we have a 'close' button instead of 'cancel' when creating a new category).

[laoneo]

Perhaps I did change the branches too fast and the labels are still the same. Then it is my fault. But the other statement from me is still valid. This should not go into a patch release.

[Fedik]

Well, ignore my last comment :)

[obuisard]

@obuisard this will fix the problem:

return $this->standardButton('cancel', $text, $task)->icon('icon-exit');

This will keep old tookbar-cancell ID but use new icon, from the linked PR.

So we don't forget @Fedik suggested adding:
->buttonClass('btn btn-primary')
so that icons turn blue.

[sdwjoomla]

Reverting the close icon change makes sense given that the replacement of the icon enhances the look and is not fixing a broken/non-loading icon. Additionally, further discussion is needed to be more consistent in the actions, using Close vs Cancel.

[brianteeman]

Additionally, further discussion is needed to be more consistent in the actions, using Close vs Cancel.

What discussion is needed - this has been the behaviour for a very very long time without issue. The only issue was regarding the icon clashing with the delete icon. Modules dont have the seperate concept of new and edit. Only components do

[sdwjoomla]

Thanks Olivier