-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Rename Login with Web Authentication to Login with Passkeys #41085
Conversation
build/media_source/plg_multifactorauth_webauthn/images/passkey.svg
Outdated
Show resolved
Hide resolved
Isn't Passkeys not only a implementation variant of Webauthn used as marketing term by MS, Apple, Google for Synced variant of webauthn ? Not sure if it make sense to rename it, maybe all add it as alternative name? |
See original issue for explanation |
@HLeithner It is, but this is really how people will be expected to use it. In a future Joomla version (maybe 6?) we can modify the passwordless login plugin to request only resident keys from the browser. This will remove the requirement for entering the username. The reason we had not implemented this yet is that hardware authenticators have a very limited memory for resident keys (Yubico only adds 10 slots in their keys) and back in early 2020 there wasn't even a way to manage them. With the introduction of passkeys this limitation is lifted since the TPM-backed software authenticator in modern browsers and OS can store an unlimited number of keys — and even sync them across devices (and, very soon, across device ecosystems). This will make hardware authenticators largely obsolete for the use cases we have for Joomla. At the same time, nobody prevents someone from creating an alternative login or MFA plugin which works with generic WebAuthn and hardware authenticators — or, better yet, allow pinning login to specific makes and models of hardware authenticators, something which might be necessary for large organisations with strict regulatory controls. So, everyone wins in the long run. |
This reverts commit 54a7951d408329a3fa24a80145391a94bb25fe29.
This reverts commit e809ddea25d9ce4f2262fe96dd5faf2cd7410ff7.
This reverts commit ee1a4e9b4e936c1bb06fdfc3369875a8b136bb37.
I have removed the changes to the svg from this PR. Lost motivation to continue with this any further (thanks to the person who sent the abusive message). This can be merged as is with a later pr for any image change or someone can submit a pr to my branch for the image and I will accept it. Otherwise I will just close it |
Based on the style guild "passkey" should be written lowercase (in our case we have some position where we write nouns uppercase even if it's not at the beginning of a sentence), the "passkeys" variant seems to only used if you reference multiple keys. Can you please change to this following the style guide? |
The style guide says
I have updated the pull request to reflect that. Thanks for pointing it out. Also added it to the style guide joomla/Manual#142 |
I have tested this item ✅ successfully on 7b4e0c1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41085. |
I will make 2 changes now and then I would merge it if you are ok with them |
Hmm created a pr brianteeman#512 but still this image is missing |
did you run the build scripts to make sure the image gets moved to the correct folder? |
you forgot to update plugins\multifactorauth\webauthn\src\Extension\Webauthn.php
|
create new images (which is needed for this) image is not my favorite task ;-) |
@HLeithner Here's the official Passkey logo as an SVG: <svg viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg" width="1.5em"><circle cx="10.5" cy="6" r="4.5"/><path d="m22.5 10.5a3.5 3.5 0 1 0 -5 3.15v5.35l1.5 1.5 2.5-2.5-1.5-1.5 1.5-1.5-1.24-1.24a3.5 3.5 0 0 0 2.24-3.26zm-3.5 0a1 1 0 1 1 1-1 1 1 0 0 1 -1 1z"/><path d="m14.44 12.52a6 6 0 0 0 -2.44-.52h-3a6 6 0 0 0 -6 6v2h13v-5.51a5.16 5.16 0 0 1 -1.56-1.97z"/></svg> |
* Add image, change login wording following the style guide * Add passkeys image for mfa method
@brianteeman sorry I think pushed to the wrong branch but the images is now included thanks to @crystalenka |
Thanks |
…omla#41085) * [5.0] Passkeys * size * fgixes * more * Revert "Auxiliary commit to revert individual files from c8db802" This reverts commit 54a7951d408329a3fa24a80145391a94bb25fe29. * Revert "Auxiliary commit to revert individual files from 8d08025" This reverts commit e809ddea25d9ce4f2262fe96dd5faf2cd7410ff7. * Revert "Auxiliary commit to revert individual files from c8db802" This reverts commit ee1a4e9b4e936c1bb06fdfc3369875a8b136bb37. * styleguide * missed one * Add image, change login wording following the style guide (joomla#512) * Add image, change login wording following the style guide * Add passkeys image for mfa method --------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Harald Leithner <leithner@itronic.at>
…omla#41085) * [5.0] Passkeys * size * fgixes * more * Revert "Auxiliary commit to revert individual files from c8db802" This reverts commit 54a7951d408329a3fa24a80145391a94bb25fe29. * Revert "Auxiliary commit to revert individual files from 8d08025" This reverts commit e809ddea25d9ce4f2262fe96dd5faf2cd7410ff7. * Revert "Auxiliary commit to revert individual files from c8db802" This reverts commit ee1a4e9b4e936c1bb06fdfc3369875a8b136bb37. * styleguide * missed one * Add image, change login wording following the style guide (joomla#512) * Add image, change login wording following the style guide * Add passkeys image for mfa method --------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Harald Leithner <leithner@itronic.at>
Pull Request for Issue #41077 .
Summary of Changes
Change verbage and change image used in the admin
Testing Instructions
Code review the text to make sure that it still makes sense
cc @nikosdion
All docs will need updating/reviewing if this PR is accepted
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: <link>
No documentation changes for manual.joomla.org needed