[5.0] Fix cli installation #41213
Merged
[5.0] Fix cli installation #41213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wilsonge that was not expected or? |
|
The PR for "cli installation" #38325 have been merged in october 2022 and the pr for "rework session/application" is last updated in june 2022... |
|
@HLeithner I also found another bug that interrupts the installation (has something to do with the compat plugin pr) |
|
Since the API system tests were also moved to cypress in 4.4, there is no longer a "test" for the cli installation 😢 |
|
Yeah as @heelc29 says. CLI came along after my PR and i didn't even think about it when rebasing. |
|
thanks |
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
installation/includes/app.phpof [5.0] Rework session/application DIC to avoid circular dependencies #36499 also for cliinstallation/includes/cli.phpinstallation/src/Application/InstallationApplication.phpof [5.0] b/c plugin for deprecation #40664 also for cliinstallation/src/Application/CliInstallationApplication.phpTesting Instructions
run
php installation/joomla.phpActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request