-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Template-param-brand #41458
[5.1] Template-param-brand #41458
Conversation
I have tested this item ✅ successfully on 8f84067 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41458. |
I would like to clarify first what is "true" and what is "false", in joomla we have a bunch of diffrent implementation what means "false" as In this case saving a bool as 0 and 1 seems to be the right thing, problem could be using it in a different like So we should check the complete codebase for inconsistency and find a solution normalize this. Pretty sure someone did this already and the PR has not been merged or has been closed or is still open don't know. I bring this topic up in the next maintainer meeting. For now I target this pr for 5.0.1 |
This comment was marked as outdated.
This comment was marked as outdated.
I have tested this item ✅ successfully on 8f84067 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41458. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41458. |
Thanks |
Pull Request for Issue #37352 .
Summary of Changes
Change the filter for brand to "options".
Testing Instructions
see #37352.
Actual result BEFORE applying this Pull Request
{"brand":"true", in database after updating a template copy
Expected result AFTER applying this Pull Request
{"brand":"1"," after updating a template copy
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed