-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Add SVG support to mod_banners #41854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for SVG, use of MediaHelper to be consistent throughout.
Deprecate isImage
I have tested this item ✅ successfully on 611d72e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41854. |
I have tested this item ✅ successfully on 611d72e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41854. |
This pull request has been automatically rebased to 5.1-dev. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41854. |
I have tested this item ✅ successfully on 9755714 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41854. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
It is possible to assign SVG files to banners, however, the module does not reflect it, only allowing image files.
Notes:
An isImage function was created specifically for Banners. However, it should not be necessary to have such a function since the MediaHelper offers it as well. To ensure Banners support the same image file extensions as the rest of the core, I opted for the use of the MediaHelper instead.
SVG files act a bit differently than image files.
When forcing a width and a height on a image, the image will 'follow' those dimensions.
A SVG file will be scaled to fit its defined viewport. So it won't 'obey' a specific height if you set one for the banner.
Depending on your situation, you may have to restrict the SVG's height with max-height.
Use of SVGs in mod_banners is safe, the SVG files are checked in MediaHelper::getMimeType.
Testing Instructions
Create banners in the administration console. Some use standard image files, some use SVG files.
Actual result BEFORE applying this Pull Request
Only banners with standard image files are shown.
Expected result AFTER applying this Pull Request
Banners with standard image files and SVG files are shown.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: link (about the deprecation)
No documentation changes for manual.joomla.org needed