[5.0] Simplify event class usage #41855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Oct 16, 2024
Resolve todo as we only support php8 now. This should probably have been done when I did joomla#41855 Original PR where this check was added joomla#28694 Signed-off-by: BrianTeeman <brian@teeman.net>
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Oct 16, 2024
Resolve todo as we only support php8 now. This should probably have been done when I did joomla#41855 Original PR where this check was added joomla#28694 Signed-off-by: BrianTeeman <brian@teeman.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
It's better to use
::classreferences to allow IDE class usage inspections.Testing Instructions
Apply path.
Actual result BEFORE applying this Pull Request
Works.
Expected result AFTER applying this Pull Request
Works as before, IDE can find the usage of event classes.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed