[5.2] foreach usage #41982
Merged
[5.2] foreach usage #41982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically rebased to 5.1-dev. |
Quy
reviewed
Oct 14, 2023
administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Oct 14, 2023
…l.php Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Quy
reviewed
Oct 16, 2023
administrator/components/com_modules/src/Controller/ModuleController.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Oct 16, 2023
…roller.php Co-authored-by: Quy <quy@nomonkeybiz.com>
|
This needs to be done carefully because a foreach makes a copy of the array and works with the copy so a foreach consume more memory. So if you've a large array you can hit the memory_limit, if it is set to a low value. |
|
This pull request has been automatically rebased to 5.2-dev. |
|
This pull request has been automatically rebased to 5.3-dev. |
Hackwar
approved these changes
Sep 11, 2024
HLeithner
previously approved these changes
Sep 11, 2024
richard67
reviewed
Sep 11, 2024
richard67
reviewed
Sep 11, 2024
laoneo
approved these changes
Sep 12, 2024
MacJoom
approved these changes
Sep 12, 2024
|
Thank you for your contribution @Denitz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Prefer foreach() over for(), especially for iterating objects. Foreach is simpler.
Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
Complex code.
Expected result AFTER applying this Pull Request
Simple code.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed