Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Remove call_user_func() #41988

Merged
merged 3 commits into from
Aug 25, 2024
Merged

Conversation

Denitz
Copy link
Contributor

@Denitz Denitz commented Sep 28, 2023

Summary of Changes

Remove call_user_func() in favour of direct call which is faster.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

Slow call_user_func() call on form field filter.

Expected result AFTER applying this Pull Request

Fast call.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@HLeithner HLeithner changed the title [5.0] Remove call_user_func() [5.1] Remove call_user_func() Sep 30, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:48
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:07
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [5.1] Remove call_user_func() [5.2] Remove call_user_func() Apr 24, 2024
@mabdelaziz77
Copy link
Contributor

I have tested this item ✅ successfully on 38bed88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988.

@pe7er
Copy link
Contributor

pe7er commented Aug 24, 2024

I have tested this item ✅ successfully on 38bed88

I tested the PR successfully.

I tested the speed using microtime and hrtime
microtime
Before 0.54661
After 0.060788

hrtime
Before 0.002111 miliseconds
After 0.001321 miliseconds

$start = hrtime(true);
// the statement
$end = hrtime(true);
$eta = ($end-$start) / 1e+6;

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988.

@pe7er pe7er added RTC This Pull Request is Ready To Commit PR-5.3-dev and removed PR-5.2-dev labels Aug 24, 2024
@richard67
Copy link
Member

richard67 commented Aug 24, 2024

@pe7er For setting RTC it is not enough to just add the label on GitHub. It needs to change status in the issue tracker. I will do that now.

P.S.: And changing just the branch label is also not right as it depends on the base branch, which is still 5.2-dev here.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 24, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2024
@Hackwar Hackwar enabled auto-merge (squash) August 25, 2024 19:25
@Hackwar
Copy link
Member

Hackwar commented Aug 25, 2024

Thank you for this contribution! 😃

@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Aug 25, 2024
@Hackwar Hackwar merged commit 9cb1e31 into joomla:5.2-dev Aug 25, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants