-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Remove call_user_func() #41988
Conversation
This pull request has been automatically rebased to 5.1-dev. |
This pull request has been automatically rebased to 5.2-dev. |
I have tested this item ✅ successfully on 38bed88 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988. |
I have tested this item ✅ successfully on 38bed88 I tested the speed using microtime and hrtime hrtime $start = hrtime(true);
// the statement
$end = hrtime(true);
$eta = ($end-$start) / 1e+6; This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988. |
@pe7er For setting RTC it is not enough to just add the label on GitHub. It needs to change status in the issue tracker. I will do that now. P.S.: And changing just the branch label is also not right as it depends on the base branch, which is still 5.2-dev here. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41988. |
Thank you for this contribution! 😃 |
Summary of Changes
Remove
call_user_func()
in favour of direct call which is faster.Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
Slow
call_user_func()
call on form field filter.Expected result AFTER applying this Pull Request
Fast call.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed