-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Cleanup input options #42166
[5.1] Cleanup input options #42166
Conversation
Remove the |
rebased it to 5.1 because it's not a bug that needs to be fixed, it's an improvement |
conflict's will be solved by upmerging 5.0 to 5.1 soon |
I have tested this item ✅ successfully on 4e2c60a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42166. |
1 similar comment
I have tested this item ✅ successfully on 4e2c60a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42166. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42166. |
Thank you @wilsonge ! |
Summary of Changes
When the live site parameter was added for some reason rather than adding just that parameter into the existing definition we re-created the entire definition
Testing Instructions
Check all global options are still available when using the CLI (such as verbosity and the live site parameter). There should be no changes but less code (yay!)
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed