[5] install from CLI deprecation php 8 #42451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @alikon Maybe line 115: $this->clientId = 2; can be removed instead? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42451. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42451. |
|
Although the fix looks good, why is this RTC without two tests? |
|
Issue trackers shows 2 successful tests though... https://issues.joomla.org/tracker/joomla-cms/42451 |
|
Thx |
|
Thx @alikon This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42451. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42436 .
Summary of Changes
declare $clientId
Testing Instructions
Install Joomla via CLI with PHP 8.x
php installation/joomla.php install --site-name="My Site name" --admin-user="Some name" --admin-username="admin" --admin-password="qwertyuiop123" --admin-email="your@emailaddress.nl" --db-type="mysqli" --db-host="localhost" --db-user="root" --db-pass="" --db-name="demoDB" --db-prefix="demo_" --db-encryption="0"
Actual result BEFORE applying this Pull Request
Deprecated: Creation of dynamic property Joomla\CMS\Installation\Application\CliInstallationApplication::$clientId is deprecated in ...\installation\src\Application\CliInstallationApplication.php on line 107
Expected result AFTER applying this Pull Request
no more deprecation
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed