-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route the redirect in the menu logout #42473
Conversation
See #37763 |
Thanks @brianteeman for the reference. Can you give it a test? So we can ship with the next release. |
I have tested this item 🔴 unsuccessfully on 501ae72 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42473. |
Sorry for the delay in responding - I had to set up a j4 dev again Using the detailed test instructions that I wrote in #37763 Before this PR I can no longer replicate the issue in that pr so it must have been solved elsewhere and I have closed it. With this PR both tests for logging out with the menu item FAIL
|
Can you test again by clearing the cookies first. This error comes mostly from the situation where the session has expired before doing the action. |
@brianteeman found the issue, can you test again? |
Repeated the tests. |
Thanks for the test, I could also only reproduce the issue on one of my sites I'm maintaining. |
Does the error also occur when you add a new logout menu item to that site? |
It happens only then. |
What kind of message do you see when this error occurs? Or does nothing just happen? |
No message, it just doesn't log out. |
I remember having the same issue with a site in the past. I can no longer reproduce it now. |
Summary of Changes
The logout via a menu item should route the redirect to logout task. This error happens on one of my production site but not on a fresh Joomla. So it is probably a configuration issue. Neverthless, all controller actions in this class are routing the requests, so should the menu logout as well.
Testing Instructions
Actual result BEFORE applying this Pull Request
Logout doesn't work on some sites.
Expected result AFTER applying this Pull Request
Logout through a menu item works direct.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed