Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Api privacy tests #42521

Merged
merged 3 commits into from
Dec 17, 2023
Merged

[5.1] Api privacy tests #42521

merged 3 commits into from
Dec 17, 2023

Conversation

brianteeman
Copy link
Contributor

Corrects the grammar for the description of a privacy test.

simple PR that can be "tested" by code review

Corrects the grammar for the description of a privacy test.

simple PR that can be "tested" by code review
@sandewt
Copy link
Contributor

sandewt commented Dec 14, 2023

I have tested this item ✅ successfully on 33e0688


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42521.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 33e0688


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42521.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42521.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 14, 2023
@richard67
Copy link
Member

richard67 commented Dec 14, 2023

@brianteeman Silly question: Why for 5.1-dev? As far as I could see on a quick view, the file is also present on 5.0-dev.

@brianteeman
Copy link
Contributor Author

@richard67 because I have given up working out which version a pr should be against as different maintainers appear to follow different criteria so I am only using the latest branch and the maintainer who merges can decide what to do.

@richard67 richard67 added the Small A PR which only has a small change label Dec 17, 2023
@LadySolveig LadySolveig merged commit cecd69b into joomla:5.1-dev Dec 17, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 17, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Dec 17, 2023
@LadySolveig
Copy link
Contributor

Thank you @brianteeman and also to the reviewers @sandewt and @richard67 !

@brianteeman brianteeman deleted the displays branch December 17, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Small A PR which only has a small change Unit/System Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants