Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] add PHP 8.3 to tests #42545

Merged
merged 2 commits into from
Dec 20, 2023
Merged

[4.x] add PHP 8.3 to tests #42545

merged 2 commits into from
Dec 20, 2023

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Dec 18, 2023

Summary of Changes

PHP 8.3 is released

Testing Instructions

Drone CI/CD

Actual result BEFORE applying this Pull Request

PHP 8.3 is not tested

Expected result AFTER applying this Pull Request

PHP 8.3 should be tested

Additional comments

Drone needs to be signed

richard67
richard67 reviewed Dec 20, 2023
View reviewed changes
.drone.yml Show resolved Hide resolved
richard67
richard67 reviewed Dec 20, 2023
View reviewed changes
.drone.yml Show resolved Hide resolved
richard67
richard67 reviewed Dec 20, 2023
View reviewed changes
.drone.yml Show resolved Hide resolved
richard67
richard67 reviewed Dec 20, 2023
View reviewed changes
.drone.yml Show resolved Hide resolved
richard67
richard67 reviewed Dec 20, 2023
View reviewed changes
.drone.yml Show resolved Hide resolved
@laoneo
Copy link
Member

laoneo commented Dec 20, 2023

@heelc29 can you remove the draft status so I can merge and will afterwards update the drone key.

@richard67
Copy link
Member

@heelc29 can you remove the draft status so I can merge and will afterwards update the drone key.

@laoneo We can do that, too. At least for me the button "Ready for review" is enabled.

@laoneo
Copy link
Member

laoneo commented Dec 20, 2023

For me as well, but I wold rather let the author doing it.

@heelc29 heelc29 marked this pull request as ready for review December 20, 2023 13:21
@heelc29
Copy link
Contributor Author

heelc29 commented Dec 20, 2023

@heelc29 can you remove the draft status so I can merge and will afterwards update the drone key.

Done

@laoneo laoneo merged commit d8648aa into joomla:4.4-dev Dec 20, 2023
1 of 2 checks passed
@laoneo
Copy link
Member

laoneo commented Dec 20, 2023

Thanks!

laoneo added a commit to Digital-Peak/joomla-cms that referenced this pull request Dec 20, 2023
@laoneo
Update the signature for joomla#42545
da8dcd5
@laoneo laoneo mentioned this pull request Dec 20, 2023
Merged
laoneo added a commit that referenced this pull request Dec 20, 2023
@laoneo
Update the signature for #42545 (#42552)
6fc05f7
@laoneo laoneo added this to the Joomla! 4.4.2 milestone Dec 20, 2023
@heelc29 heelc29 deleted the 4.4/tests-php83 branch December 20, 2023 17:21
Razzo1987 added a commit that referenced this pull request Jan 4, 2024
@Razzo1987 @RickR2H
@heelc29 @laoneo @richard67 @brianteeman @wilsonge @alikon @bembelimen @SniperSister @janschoenherr
[5.1] upmerge 2024-01-04 (#42609)
cb6bba1 
* Fix link and button colors in header footer (#42504)

* [4.x] add php 8.3 to tests (#42545)

* Update the signature for #42545 (#42552)

* [4.4] Joomlaupdate remove br tag from language strings - follow up to PR 42489 (#42550)

* Better English (1)

* Better English (2)

* Remove br html element from language strings

* Fixes to form validation process (#42560)

Fixes hardening measure introduced in #23716

* [4][com_actionlogs] missed load plugin languages (#42562)

* load lang

* test-4-dupkey

* Better message on package uninstallation (#42570)

* Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 .

* backport #41865 (#42088)

* backport [5] update from nightly to latest nightly build #41865

* [5] harmonize naming task types (#42574)

* [5.0] colour contrast in media manager file list [a11y] (#42544)

* [5.0] Update phpseclib to 3.0.34 (#42469)

* Fix `function` parameter lost during redirect (#42315)

* Fix `function` parameter lost during redirect

* Move function parameter to form url

* Remove hidden input

* [4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN_SIZE rows" when checking for core updates (#42576)

* Use concat of columns for getting core extensions

* Fix PHPCS

* Remove wrong quotes

* Revert min version in drone (#42583)

* Joomla! 5.0.2 Release Candidate 1

* Revert to dev

* [4][com_templates] cast to int for pgsql (#42569)

* cast to int for pgsql

* yet-another

* patch article tags (#42486)

* Joomla 5.0.2 Release Candidate 2

* Reset to dev

* Update signature HMAC in .drone.yml

---------

Co-authored-by: Rick Spaan <rick@r2h.nl>
Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com>
Co-authored-by: Benjamin Trenkle <benjamin.trenkle@wicked-software.de>
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Co-authored-by: David Jardin <d.jardin@djumla.de>
Co-authored-by: janschoenherr <jan@yootheme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard67 richard67 richard67 left review comments

@laoneo laoneo laoneo left review comments

@rdeutz rdeutz Awaiting requested review from rdeutz rdeutz is a code owner

@Hackwar Hackwar Awaiting requested review from Hackwar Hackwar is a code owner

Assignees
No one assigned
Labels
PR-4.4-dev Unit/System Tests
Projects
None yet
Milestone
Joomla! 4.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@heelc29 @laoneo @richard67 @joomla-cms-bot