-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Feed: Fixing link selection of AtomParser #42706
Conversation
I have tested this item ✅ successfully on 231e360 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42706. |
Hi @Hackwar i'm testing this PR but i don't see a change in the dom of the urls of the blog items in the feed. they all have rel="noopener" even after applying the patch. But i do notice a change in behaviour as that now it opens the actual article instead of the feed link when clicking on the items. Seems like a half successfull test no? ![]() |
@TLWebdesign that is the expected behavior, so your test would be successfull. |
I have tested this item ✅ successfully on 231e360 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42706. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42706. |
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Thank you! |
Pull Request for Issue #38631 .
Summary of Changes
The feed parser for Atom feeds is selecting the wrong link as described in the original issue.
Testing Instructions
Copied from the original issue:
https://www.failureasaservice.com/feeds/posts/default
Actual result BEFORE applying this Pull Request
Link is created using the first entry
<link rel="replies">
which is an XML feed and not useful for normal users who just want to jump over to your post on Blogger.com.Expected result AFTER applying this Pull Request
Links should use the
<link rel="alternate">
entry creating a clickable jump back to the Blogger page.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed