[5.2] Minor cleanup for plugins JS #42797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
dgrammatiko
reviewed
Feb 12, 2024
Fedik
reviewed
Feb 12, 2024
build/media_source/plg_system_schedulerunner/js/run-schedule.es6.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
dgrammatiko
reviewed
Feb 12, 2024
build/media_source/plg_system_schedulerunner/js/run-schedule.es6.js
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically rebased to 5.2-dev. |
HLeithner
changed the title
|
I have tested this item ✅ successfully on 0a28f6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42797. |
1 similar comment
|
I have tested this item ✅ successfully on 0a28f6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42797. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42797. |
|
Thanks @C-Lodder ! |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Oct 17, 2024
* Minor cleanup for plugins JS * Update build/media_source/plg_captcha_recaptcha/js/recaptcha.es6.js * Fix
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As Joomla no longer supports IE11, this PR mainly removes the need for converting a NodeList to an Array, as evergreen browser's implementation of
forEachcan iterater over a NodeList.Also includes some other minor tweaks.
Testing Instructions
Code review @dgrammatiko @Fedik