Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Load Schema.org only in proper forms #42825

Merged
merged 11 commits into from
Jul 7, 2024

Conversation

n3t
Copy link
Contributor

@n3t n3t commented Feb 16, 2024

Load and display scheme.org form only in contexts that component propagate as available.

Summary of Changes

Modified Schemaorg system plugin to load Schema form only in contexts, that are promoted by component as available.

Testing Instructions

Not testable on core, as com_content and com_contact both has only one edit view, one edit form. Need 3rd party component with support of SchemaorgServiceInterface.
Dev version of PhocaCart could be used (not released at the moment). If necessary I could prepare dummy component just for testing this.

Actual result BEFORE applying this Pull Request

If the component provides multiple forms, schema.org form is added to all of its forms, not only to forms declared in
getSchemaorgContexts function.

Expected result AFTER applying this Pull Request

Schema org fields are loaded only on proper forms.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@n3t n3t changed the title Update Schemaorg.php [5.0] Update Schemaorg.php Feb 16, 2024
@n3t n3t changed the title [5.0] Update Schemaorg.php [5.0] Load Schema.org only in proper forms Feb 16, 2024
@Fedik Fedik added the bug label Feb 17, 2024
@PhocaCz
Copy link
Contributor

PhocaCz commented Feb 17, 2024

I have tested this item ✅ successfully on 7d5f44f

Hi,

testing with latest Phoca Cart 5 Beta version: https://github.com/PhocaCz/PhocaCart/releases/download/5.0.0Beta/com_phocacart_v5.0.0Beta26.zip

Before:
img
(additional tab is displayed)

After:
img
(no additional tab is displayed)

Tested sucessfully ✓


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.

@coufalpetr
Copy link

I have tested this item ✅ successfully on 7d5f44f

Hi, I have installed the latest Phoca Cart Beta version, after installing this patch I don't see any extra unnecessary tab. So the result is successful.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.

@richard67 richard67 removed the bug label Feb 20, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 20, 2024
@richard67 richard67 added the bug label Feb 20, 2024
@bembelimen bembelimen changed the base branch from 5.0-dev to 5.1-dev March 13, 2024 23:16
@cybersalt
Copy link

I have tested this item ✅ successfully on 660b142

Also used Phocacart in testing - it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.

@HLeithner HLeithner changed the title [5.0] Load Schema.org only in proper forms [5.1] Load Schema.org only in proper forms Apr 24, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 660b142


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.

@n3t
Copy link
Contributor Author

n3t commented May 29, 2024

Just curious, this PR is marked RTC since 3 months ago, but still not commited, so missing in 5.1.1 release, is there any issue with it? Should I add something?

@LadySolveig LadySolveig modified the milestones: Joomla! 5.1.1, 5.1.2, Joomla! 5.1.2 May 30, 2024
@LadySolveig LadySolveig modified the milestones: 5.1.2, Joomla! 5.1.2 May 30, 2024
@bembelimen bembelimen merged commit d5047c7 into joomla:5.1-dev Jul 7, 2024
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 7, 2024
@n3t n3t deleted the n3t-patch-schemaorg branch July 16, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants